Uh oh!
There was an error while loading. Please reload this page.
(2) Feat/filters - #390
Merged
Merged
Conversation
…ot define a behavior for dates
Tanguylo
marked this pull request as ready for review
June 19, 2024 09:41
GhislainJ
requested changes
Jul 3, 2024
| maxValue + valueRange * this.marginRatio]; | ||
| } | ||
| public setRubberbandRange(minValue: string, maxValue: string): void { |
CollaboratorAuthor
There was a problem hiding this comment.
It is for handling the input in html debug mode.
I guess i can handle both types
Collaborator
There was a problem hiding this comment.
Having an union of both is even more confusing.
Why not having a non-exposed proxy function used just by debug mode, that would translate minValue and maxValue to numbers and call the setRubberbandRange that would just handle number values ?
Uh oh!
There was an error while loading. Please reload this page.
GhislainJ
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.