Skip to content

DVC-8633: feat: add overrides update - #277

Merged
suthar26 merged 1 commit into
mainfrom
DVC-8633-add-overrides-update
Sep 7, 2023
Merged

DVC-8633: feat: add overrides update#277
suthar26 merged 1 commit into
mainfrom
DVC-8633-add-overrides-update

Conversation

@suthar26

@suthar26suthar26 commented Sep 5, 2023

Copy link
Copy Markdown
Contributor
  • happy path without flags
  • need to test headless mode and without some flags
  • need to test when user id is not set
  • improve the output to be user relevant info only

@suthar26

Copy link
Copy Markdown
ContributorAuthor

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@suthar26
suthar26force-pushed the DVC-8633-add-overrides-update branch from 06ced91 to 4fd9bbcCompareSeptember 6, 2023 18:02
@suthar26
suthar26 marked this pull request as ready for review September 6, 2023 18:06
@suthar26
suthar26force-pushed the DVC-8633-add-overrides-update branch from 4fd9bbc to ac1382dCompareSeptember 6, 2023 18:06
@suthar26
suthar26force-pushed the DVC-8633-add-overrides-update branch 2 times, most recently from 29afd06 to 2603595CompareSeptember 6, 2023 18:08
@suthar26
suthar26 requested a review from a teamSeptember 6, 2023 18:09
Comment threadREADME.md Outdated
Comment threadsrc/api/zodClient.ts
_environment: z.string(),
_feature: z.string(),
_variation: z.string(),
dvcUserId: z.string(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this support empty strings, null and undefined?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but we would only get the response for the UpdateCommand if all values are set and this is the return object

Comment threadsrc/api/zodClient.ts Outdated
Comment threadsrc/commands/overrides/update.ts Outdated
@suthar26
suthar26force-pushed the DVC-8633-add-overrides-update branch from 93e9641 to b368604CompareSeptember 6, 2023 19:20
@suthar26
suthar26 enabled auto-merge (rebase) September 6, 2023 19:23
Comment threadsrc/commands/overrides/update.ts Outdated
Comment threadsrc/commands/overrides/update.ts Outdated
@suthar26
suthar26force-pushed the DVC-8633-add-overrides-update branch 2 times, most recently from 8e820d3 to 7d3c24fCompareSeptember 7, 2023 17:52
Comment threaddocs/overrides.md Outdated
@suthar26
suthar26force-pushed the DVC-8633-add-overrides-update branch from 7d3c24f to a24bcb2CompareSeptember 7, 2023 18:03
@suthar26
suthar26 merged commit 312ea3a into mainSep 7, 2023
@suthar26
suthar26 deleted the DVC-8633-add-overrides-update branch September 7, 2023 18:06
jonathannorris added a commit that referenced this pull request Jul 27, 2026
- fast-uri 3.1.2 -> 3.1.4 (high, alerts #275/#277)
- sharp 0.34.5 -> 0.35.0 (high, alert #276)
- @hono/node-server 1.19.13 -> 2.0.5 (medium, alert #274)
- shell-quote 1.8.4 -> 1.9.0 (high, alert #273)
- sigstore 1.9.0 -> 4.1.1 (high, alert #263)
jonathannorris added a commit that referenced this pull request Jul 27, 2026
* chore: resolve open dependabot security alerts
- fast-uri 3.1.2 -> 3.1.4 (high, alerts #275/#277)
- sharp 0.34.5 -> 0.35.0 (high, alert #276)
- @hono/node-server 1.19.13 -> 2.0.5 (medium, alert #274)
- shell-quote 1.8.4 -> 1.9.0 (high, alert #273)
- sigstore 1.9.0 -> 4.1.1 (high, alert #263)
* chore: revert sharp bump due to new LGPL-licensed libvips artifact
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@suthar26@ajwootto@kaushalkapasi@chantalchung