Skip to content

DVC-8772 chore: filter prompts for overrides - #284

Merged
suthar26 merged 1 commit into
mainfrom
DVC-8772-show-useful-information
Sep 11, 2023
Merged

DVC-8772 chore: filter prompts for overrides#284
suthar26 merged 1 commit into
mainfrom
DVC-8772-show-useful-information

Conversation

@suthar26

@suthar26suthar26 commented Sep 11, 2023

Copy link
Copy Markdown
Contributor
  • tested locally by changing the number of overrides through dashboard
Screenshot 2023-09-11 at 2 40 44 PM

@suthar26

Copy link
Copy Markdown
ContributorAuthor

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@suthar26
suthar26 requested a review from a teamSeptember 11, 2023 15:45
@suthar26
suthar26force-pushed the DVC-8772-show-useful-information branch 3 times, most recently from 328f029 to 220313cCompareSeptember 11, 2023 16:20
value: feature
})
}
return autocompleteSearch(choices, search)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some kind of empty state message if there are no features with overrides (choices array is empty) - same case for environments below
image
I'm stuck on this step when I have no overrides

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess will add!

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same thing that happens when you create a project with no features and do feature update the list is empty.. couldn't find a way to make it not not execute here without making an extra call to the api

@kaushalkapasikaushalkapasiSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just escape early, if no results found then return and say No Overrides found to be cleared. with an info print

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added empty states

@suthar26
suthar26force-pushed the DVC-8772-show-useful-information branch 5 times, most recently from afe5b15 to c2b94aeCompareSeptember 11, 2023 18:45
@suthar26
suthar26force-pushed the DVC-8772-show-useful-information branch from c2b94ae to 214fa83CompareSeptember 11, 2023 18:49
@suthar26
suthar26 merged commit 90079ac into mainSep 11, 2023
@suthar26
suthar26 deleted the DVC-8772-show-useful-information branch September 11, 2023 19:05
jonathannorris added a commit that referenced this pull request Aug 5, 2026
* chore: resolve open dependabot security alerts
- brace-expansion ^1.1.16 -> ^1.1.18 (high, alerts #285/#286)
- brace-expansion ^2.1.2 -> ^2.1.4 (high, alerts #282/#287)
- undici ^7.28.0 -> ^7.29.0 (medium/high, alerts #289-#293)
- ip-address ^10.1.1 -> ^10.3.1 (medium/high, alerts #283/#284/#294)
- hono ^4.12.25 -> ^4.12.34 (medium, alert #295)
- fast-uri ^3.1.4 -> ^3.1.5 (high, alert #288)
- wrangler ~4.116.0 (via miniflare 4.20260730.0 -> sharp 0.35.2, high, alert #276)
* chore: exclude @img/sharp-libvips-linux-x64@1.3.1 from license check
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@suthar26@kaushalkapasi@chantalchung