Skip to content

Microsoft Mvvm Toolkit support - #17

Draft
VitalyTVA wants to merge 21 commits into
22.1.1from
22.1.2_MvvmToolkit
Draft

Microsoft Mvvm Toolkit support#17
VitalyTVA wants to merge 21 commits into
22.1.1from
22.1.2_MvvmToolkit

Conversation

@VitalyTVA

@VitalyTVAVitalyTVA commented Jun 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

VitalyTVA added 20 commits May 31, 2022 23:17
@VitalyTVA
MvvmToolkit - GenerationUnitTests
53dcf3b
@VitalyTVA
MvvmToolkit - diagnostics tests
ff220bc
@VitalyTVA
Reove duplicated code
fad0b61
@VitalyTVA
MvvmToolkit PropertyGenerationTests
ff4a1fe
@VitalyTVA
UpdateRaiseMtehod tests for MvvmToolkit + support OnPropertyChang[ed|…
ccb8d8a
…ing] methods in addition to Raise* methods
@VitalyTVA
fix FirstOrDefaultError
e920075
@VitalyTVA
MvvmToolkit - support only OnPropertyChang[ed|ing] methods
4ee3787
@VitalyTVA
fix simple warnings
a5e555b
@VitalyTVA
fix excessive interface generation in child classes if interface impl…
36096ed
…mentation is generated in parent class
@VitalyTVA
MvvmToolkit interfaces and nullability tests
b241253
@VitalyTVA
Toolkit command generation tests
11ef1cc
@VitalyTVA
Toolkit attribute transfer tests
744366a
@VitalyTVA
Toolit async commands generation
c95cc6f
@VitalyTVA
GetParents instead for cycle
14939d2
@VitalyTVA
MvvmToolkit Broadcast option
ef7ed65
@VitalyTVA
refactoring - remove duplicated code from tests
a6ad9a6
@VitalyTVA
MvvmToolkit Validate=true option support
1ef30b7
@VitalyTVA
Update readme
b0d8946
@VitalyTVA
Update readme - list supported mvvm frameworks
5c13f68
@VitalyTVA
Fix typo in readme
bc8e09c
AlexanderEgorov
AlexanderEgorov suggested changes Jun 24, 2022
View reviewed changes

@AlexanderEgorovAlexanderEgorov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a deep review. I didn't check out this pull request.

Comment threadDevExpress.Mvvm.CodeGenerators.Tests/UnitTests/UnitTests.csproj Outdated
Comment threadDevExpress.Mvvm.CodeGenerators.Tests/SharedTests/MvvmToolkit/AttributeTransferTests.cs Outdated
Comment threadDevExpress.Mvvm.CodeGenerators.Tests/SharedTests/MvvmToolkit/NullableAnnotationTests.cs Outdated
Comment threadDevExpress.Mvvm.CodeGenerators/Diagnostics/GeneratorDiagnostics.cs
Comment threadDevExpress.Mvvm.CodeGenerators/Info/ContextInfo.cs Outdated
Comment threadDevExpress.Mvvm.CodeGenerators/Info/ContextInfo.cs Outdated
Comment threadDevExpress.Mvvm.CodeGenerators/Info/INPCInfo.cs Outdated
Comment threadDevExpress.Mvvm.CodeGenerators/Info/INPCInfo.cs Outdated
Comment threadDevExpress.Mvvm.CodeGenerators/Generators/PropertyGenerator.cs
.Append('(')
.Append(propertyName)
.Append("Chang")
.Append(suffix)

@AlexanderEgorovAlexanderEgorovJun 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a recommendation: Instead of a set of Append calls, make an extension method that accepts 'params string[]'

@VitalyTVAVitalyTVAJun 24, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Append" calls are chained to avoid excessive memory traffci and improve performance. Correct approach is to use Interpolated String Handler available in C# 10. Probably somewhere in the future.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@AlexanderEgorovAlexanderEgorovAlexanderEgorov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VitalyTVA@AlexanderEgorov