Skip to content

Fix CI for MacOS and Numpy2.0 - #158

Merged
AlexanderWells-diamond merged 5 commits into
masterfrom
macos_ci_fix
Sep 18, 2024
Merged

Fix CI for MacOS and Numpy2.0#158
AlexanderWells-diamond merged 5 commits into
masterfrom
macos_ci_fix

Conversation

@AlexanderWells-diamond

@AlexanderWells-diamondAlexanderWells-diamond commented Apr 24, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

The current macos-latest tag points to macos-14, running on arm64. We currently can't support this architecture as it does not support Python3.7.

The current supported tags/runners is documented here: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

This is not a permanent fix and should be re-visited as part of issue #159

Secondly this PR handles the upgrade of various upstream dependencies to now work with Numpy>= 2.0.

@github-actions

github-actionsBot commented Apr 24, 2024•
edited
Loading

Copy link
Copy Markdown

Unit Test Results

0 files - 9 0 suites - 9 0s ⏱️ - 14m 54s
0 tests - 315 0 ✔️ - 299 0 💤 - 16 0 ❌ ±0 
0 runs - 2 835 0 ✔️ - 2 370 0 💤 - 465 0 ❌ ±0 

Results for commit c13766c. ± Comparison against base commit 3b0bef0.

♻️ This comment has been updated with latest results.

@AlexanderWells-diamondAlexanderWells-diamond mentioned this pull request Apr 24, 2024
Closed
@codecov

codecovBot commented Apr 24, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (7babcde) to head (5e6f48e).
Report is 6 commits behind head on master.

❗ Current head 5e6f48e differs from pull request most recent head 714c5ab. Consider uploading reports for the commit 714c5ab to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## master #158 +/- ##
==========================================
- Coverage 88.15% 87.32% -0.83% 
==========================================
Files 14 14 Lines 1038 1057 +19 ==========================================
+ Hits 915 923 +8 - Misses 123 134 +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexanderWells-diamond
AlexanderWells-diamondforce-pushed the macos_ci_fix branch 2 times, most recently from bc30662 to 714c5abCompareApril 24, 2024 10:29
@AlexanderWells-diamond

AlexanderWells-diamond commented Apr 24, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

On hold pending p4p support for Numpy 2.0 and Python 3.12 support. Current latest PR in the chain is: epics-base/p4p#152

@AlexanderWells-diamond
AlexanderWells-diamond marked this pull request as draft April 24, 2024 11:10
@AlexanderWells-diamondAlexanderWells-diamond mentioned this pull request Jun 7, 2024
Merged
@AlexanderWells-diamondAlexanderWells-diamond mentioned this pull request Aug 21, 2024
Closed
@AlexanderWells-diamond

AlexanderWells-diamond commented Sep 10, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Note there's now a pin for numpy<2.0 in setup.py, which should be removed when this PR is worked on again.

@AlexanderWells-diamond
AlexanderWells-diamondforce-pushed the macos_ci_fix branch 3 times, most recently from 42cc1f0 to dfc03acCompareSeptember 18, 2024 12:07
@AlexanderWells-diamond
Downgrade MacOS CI runners
871b4d2
The current macos-latest tag points to macos-14, running on arm64. We
currently can't support this architecture as it does not support
Python3.7
Revert 1bbc27b
@AlexanderWells-diamond
Add CI for Python 3.11 and 3.12
5d30a51
Had to update the setup-python version to allow a version of
cibuildwheel that supports python 3.12.
@AlexanderWells-diamond
Remove Unit Test Results
69bc9ea
In several years I don't think I've ever actually looked at them...
@AlexanderWells-diamond
Remove numpy pin and bump p4p
cbfa6eb
This p4p release should now support numpy 2.0.
Bump epicscorelibs to required version for p4p
@AlexanderWells-diamond
Add logging to problematic test
8db9cd9
@AlexanderWells-diamondAlexanderWells-diamond changed the title Downgrade MacOS CI runnersFix CI for MacOS and Numpy2.0Sep 18, 2024
@AlexanderWells-diamond

AlexanderWells-diamond commented Sep 18, 2024

Copy link
Copy Markdown
CollaboratorAuthor

We still have a failure for Windows with Python 3.12, but that's waiting on a Numpy release after this PR was merged. We're going to merge these changes anyway, because once that is released everything should just work...

@AlexanderWells-diamond
AlexanderWells-diamond marked this pull request as ready for review September 18, 2024 13:11
@AlexanderWells-diamond
AlexanderWells-diamond deleted the macos_ci_fix branch September 18, 2024 13:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AraneidaeAraneidaeAwaiting requested review from Araneidae

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlexanderWells-diamond