Skip to content

Fix infinite loop when setting record's own value from on_update callback - #202

Merged
AlexanderWells-diamond merged 2 commits into
masterfrom
reimplement_db_put_field
Feb 4, 2026
Merged

Fix infinite loop when setting record's own value from on_update callback#202
AlexanderWells-diamond merged 2 commits into
masterfrom
reimplement_db_put_field

Conversation

@AlexanderWells-diamond

@AlexanderWells-diamondAlexanderWells-diamond commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

This works around issues with potential infinite loops, even if process=False, as seen in issue #201.

Closes#201

@codecov

codecovBot commented Feb 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.39%. Comparing base (09ea964) to head (8034e3a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #202 +/- ##
==========================================
+ Coverage 88.16% 88.39% +0.22% 
==========================================
Files 15 15 Lines 1259 1258 -1 ==========================================
+ Hits 1110 1112 +2 + Misses 149 146 -3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexanderWells-diamondAlexanderWells-diamond changed the title Use our own implementation of dbPutFieldFix infinite loop when setting record's own value from on_update callbackFeb 3, 2026
This works around issues with potential infinite loops, even if
process=False, as seen in issue #201.

@AraneidaeAraneidae left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have two minor layout changes I'd prefer to see for the sake of consistency, but this seems good to me.

Comment threadsoftioc/extension.c Outdated
Comment threadsoftioc/extension.c
@AlexanderWells-diamond
AlexanderWells-diamond merged commit 3126269 into masterFeb 4, 2026
47 checks passed
@AlexanderWells-diamond
AlexanderWells-diamond deleted the reimplement_db_put_field branch February 4, 2026 14:09
AlexanderWells-diamond added a commit that referenced this pull request Jul 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite loop when setting value in record's on_update callback

2 participants

@AlexanderWells-diamond@Araneidae