Skip to content

Add native commands supports to every modules - #120

Open
Bricklou wants to merge 12 commits into
DigitalPulseSoftware:masterfrom
Bricklou:feature/commands-enhancement
Open

Add native commands supports to every modules#120
Bricklou wants to merge 12 commits into
DigitalPulseSoftware:masterfrom
Bricklou:feature/commands-enhancement

Conversation

@Bricklou

@BricklouBricklou commented Jul 4, 2026•
edited
Loading

Copy link
Copy Markdown

Currently, NaB only support message commands. This PR is here to provide a support for a subset of common commands for a better user experience.

@Bricklou
Bricklou marked this pull request as ready for review July 4, 2026 12:51
Equinox4
Equinox4 suggested changes Jul 4, 2026
View reviewed changes
Comment threadmodule_prune.lua Outdated
Comment threadmodule_prune.lua Outdated
Comment threadmodule_prune.lua
Elanis
Elanis reviewed Jul 4, 2026
View reviewed changes

@ElanisElanis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What started out as a code review ended up turning into an english-focused review 😅

Comment threadmodule_message.lua Outdated
Comment threadmodule_message.lua Outdated
Comment threadmodule_message.lua Outdated
Comment threadmodule_message.lua Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
@Bricklou
Bricklou requested a review from Equinox4July 4, 2026 19:38
@Bricklou
Bricklouforce-pushed the feature/commands-enhancement branch from bcd34f4 to a80865dCompareJuly 6, 2026 18:23
Elanis
Elanis approved these changes Jul 6, 2026
View reviewed changes

@ElanisElanis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Equinox4
Equinox4 reviewed Jul 7, 2026
View reviewed changes

@Equinox4Equinox4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bricklou
Bricklou requested a review from Equinox4July 15, 2026 08:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@ElanisElanisElanis approved these changes
@Equinox4Equinox4Equinox4 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bricklou@Elanis@Equinox4