Uh oh!
There was an error while loading. Please reload this page.
Allow loading mods from version-specified directory i.e. mods/rift/1.13/ - #65
Allow loading mods from version-specified directory i.e. mods/rift/1.13/#65k-jiang wants to merge 7 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
create "mods/rift/" folder by default Rift's mods should be inside "mods/rift/" or "mods/rift/_version_", no more "mods/_version_-Rift/" load mods from classpath, "mods/rift/_version_", "mods/rift/" and "mods/" classpath mods are now loaded and logged separately to avoid confusion
OK, I modify the loading process, now the logic is:
The reason why I chose lower-case for "rift" is to eliminate any case-sensitive scenario and confusion, just like forge. Any ideas? |
0f-0b
left a comment
There was a problem hiding this comment.
Suggest changes for readability and performance.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fix case sensitive. Co-Authored-By: k-jiang <k@kjiang.net>
Improve readability. Co-Authored-By: k-jiang <k@kjiang.net>
Let Rift to try loading mods form the
mods/"version"-Riftfolder. If empty, fall back to "mods/" instead.p.s. I removed the "final" flag from variable
modsDir, not sure if there are any consequences.