Uh oh!
There was an error while loading. Please reload this page.
fix(schema): correct Metadata.generator.version type number → string (#150) - #163
Merged
nathanacurtis merged 3 commits intoJun 16, 2026
Merged
Conversation
…150) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nathanacurtis added a commit
that referenced
this pull request
Jun 16, 2026
…li v0.21.0 (#165) * chore(release): improve changelog quality guidance in release agents Require human-friendly prose in release summaries and individual bullets ("So what?" framing, not API descriptions). Add empty-section pruning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(schema): rename SlotProp.minItems/maxItems to minChildren/maxChildren (ADR-056) (#158) * chore(release): improve changelog quality guidance in release agents Require human-friendly prose in release summaries and individual bullets ("So what?" framing, not API descriptions). Add empty-section pruning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(schema): rename SlotProp.minItems/maxItems to minChildren/maxChildren (ADR-056) Aligns slot constraint field names with Figma native slotSettings API. Adds anyOf to SlotProp, populated from preferredValues when allowPreferredValuesOnly is true. Bumps schema to 0.25.0 (breaking change). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * adr(056): mark ADR-056 as accepted Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: update slot constraints docs for minChildren/maxChildren rename (ADR-056) Updates schema/props, config/slot-constraints, guides/slot-constraints, and analyze/props to reflect the minItems/maxItems → minChildren/maxChildren rename and the new native slotSettings source alongside code-only props. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(adr): derive RELEASE_BRANCH from git branch list, not package.json Specs.adr.implement.agent.md was constructing the release branch name from the package.json version, which produces a name that does not exist when the branch includes multiple packages (e.g. release/schema-0.25.0-cli-0.21.0). Now runs git branch -a | grep release/ and uses the actual branch name. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(analyze): respect format.output for props and styling analyzers (#151) (#160) Props always wrote YAML; styling always wrote JSON. Both now read outputFormat from TransformerContext and produce .yaml or .json output (file extension + serializer) matching config.format.output. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * adr(057): claim ADR number — generator.version number → string * fix: emit CSS for enum-valued state variants without explicit value (#157) (#162) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(schema): correct Metadata.generator.version type number → string (#150) (#163) * adr(057): claim ADR number — generator.version number → string * fix(schema): correct Metadata.generator.version type number → string (#150) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * release: @directededges/specs-schema v0.25.0 * release: @directededges/specs-cli v0.21.0 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metadata.generator.versionwas typed asnumberin bothtypes/Metadata.tsandcomponent.schema.json, but all producers (plugin, CLI) have passed semver strings (e.g."1.10.0") since v0.22.0. This PR corrects the type and schema to match actual usage.Test coverage
tests/Metadata.test-d.tsfixtures to use semver strings@ts-expect-errorassertion confirmingnumberis rejectedtsc -p tsconfig.build.json,validate-schema.sh,tsc --noEmit tests/Metadata.test-d.tsCloses#150