Skip to content

complete interactions/buttons.mdx page - #60

Open
dlchamp wants to merge 11 commits into
DisnakeDev:mainfrom
dlchamp:feat-complete-buttons-guide
Open

complete interactions/buttons.mdx page#60
dlchamp wants to merge 11 commits into
DisnakeDev:mainfrom
dlchamp:feat-complete-buttons-guide

Conversation

@dlchamp

@dlchampdlchamp commented Aug 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Complete the interactions/buttons page

  • Add basic View example
  • Add example for handling timeout and View.stop (disabled buttons and clear_items)
  • Move low level example to Views vs low-level section

Relevant Issues

Closes#59

@dlchamp
complete buttons.mdx
f6e0d5a
- Add basic View example
- Add example for handling timeout (disabling buttons and clear_items)
- Move low level example to Views vs low-level section
@shiftinvshiftinv added t: page/section addition Pull Request to add new content to the guide. t: enhancement s: needs review labels Aug 15, 2023
shiftinv
shiftinv reviewed Aug 27, 2023
View reviewed changes

@shiftinvshiftinv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! This looks good, most of my comments are about formatting and other minor nits.

A more general comment about the entire guide's structure:
With the addition of this page, the guide starts having some redundancy between the pages for buttons and select menus, both regarding view timeouts and low-level components.
This isn't relevant to this PR directly, but we should refactor common sections into a separate page in the future.

Comment threadguide/docs/interactions/buttons.mdx
Comment threadguide/docs/interactions/buttons.mdx Outdated
Comment threadguide/docs/interactions/buttons.mdx Outdated
Comment threadguide/docs/interactions/buttons.mdx Outdated
Comment threadguide/docs/interactions/buttons.mdx Outdated
Comment threadguide/docs/interactions/buttons.mdx Outdated
Comment threadguide/docs/interactions/buttons.mdx
Comment threadguide/docs/interactions/buttons.mdx Outdated
Comment threadguide/docs/interactions/buttons.mdx Outdated
Comment threadguide/docs/interactions/buttons.mdx Outdated
@dlchamp

dlchamp commented Aug 27, 2023

Copy link
Copy Markdown
ContributorAuthor

ty! This looks good, most of my comments are about formatting and other minor nits.

A more general comment about the entire guide's structure: With the addition of this page, the guide starts having some redundancy between the pages for buttons and select menus, both regarding view timeouts and low-level components. This isn't relevant to this PR directly, but we should refactor common sections into a separate page in the future.

I was thinking the same thing as I was working on this.

dlchampand others added 9 commits August 27, 2023 10:01
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
b517a00
remove unnecessary "default timeout" comment
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
7a659cc
correct View Example link
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
09eaf56
remove unneeded comment in disabled button example
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
cde1dab
adjust comment structure in button_view example
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
7c72a30
remove ellipses from example
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
b919751
remove unnecessary comment in timeout example
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
222c413
wording in timeout example slash command
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp@shiftinv
Update guide/docs/interactions/buttons.mdx
f7c17bf
remove unneeded custom_id check in low level example
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: DLCHAMP <36091350+dlchamp@users.noreply.github.com>
@dlchamp
reword and reduce comments
d0bc2a3
reword comments in timeout example
remove duplicate comments from second button callback.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftinvshiftinvshiftinv left review comments
@abhigyantripsabhigyantripsAwaiting requested review from abhigyantrips

Assignees

No one assigned

Labels

s: needs reviewt: enhancementt: page/section additionPull Request to add new content to the guide.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: Complete interactions/buttons page

2 participants

@dlchamp@shiftinv