Merge existing video notes into media-notes. - #1
Merged
Merged
Conversation
Bring the current videonote collection into the repository's media-note layout, preserve the RAG note assets, update the index, and add publishing metadata for all merged notes.
There was a problem hiding this comment.
🟡 Changes recommended
One newly added note uses a source URL format that will be published into frontmatter as an invalid link, and the README naming rule currently contradicts the actual filenames listed/added.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Integrates additional video-note content into the repository’s media-note/ layout and wires the new notes into the publishing pipeline by extending the publish metadata config and updating the note index.
Changes:
- Extended
scripts/publish.config.mjswith publishing metadata (slug/category/EN title+summary) for newly merged notes. - Added a new media note (
测试开发学习路线笔记.md) undermedia-note/. - Updated
media-note/README.mdto document layout expectations and include the new notes in the index table.
File summaries
| File | Description |
|---|---|
| scripts/publish.config.mjs | Adds publishing metadata entries for additional merged notes so publish-notes.mjs can generate frontmatter. |
| media-note/测试开发学习路线笔记.md | New merged note content with source block and structured sections. |
| media-note/README.md | Updates indexing and documentation for where notes/assets live and includes new index rows. |
Review details
Suppressed comments (1)
media-note/测试开发学习路线笔记.md:2
- 来源链接使用了 Markdown 的 <...> 包裹形式，publish-notes.mjs 的 parseSourceBlock 会把尖括号也当作 URL 字符串写入 frontmatter，导致站点上的 sourceUrl 变成包含 <> 的无效链接。建议改为普通的 (https://...) 形式。
- Files reviewed: 9/19 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ## 命名 | ||
|
|
||
| `<标题或内容主题> <类型>.md`，类型为 `笔记` / `指南` / `手册` 之一。 | ||
| `<标题或内容主题> <类型>.md`，类型为 `笔记` / `指南` / `手册` 之一。历史笔记如保留“学习笔记”字样，也按内容类型归档。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the current videonote collection into the repository's media-note layout, preserve the RAG note assets, update the index, and add publishing metadata for all merged notes.