Uh oh!
There was an error while loading. Please reload this page.
Configure user settings from the environment - #329
Conversation
This eliminates a manual step in the build process.
This allows setting environment variables rather than editing init.sh and sets default values when the variables aren't found in the environment.
SkewedZeppelin
commented
Aug 2, 2024
Overrides can already be provided via a drop-in DivestOS-Build/Scripts/init.sh Line 106 in 2bb4d94 |
f9f6560 to
39a9117CompareI hadn't noticed that so I'll have to give that a try, thanks! |
ryneeverett
commented
Aug 6, 2024
The problem with this approach is that it is no good for DOS_WORKSPACE_ROOT because DOS_SIGNING_KEYS and DOS_SIGNING_GPG build upon it so they will still point to /mnt/dos/Signing_Keys/*. Sure, one could override those too but it doesn't seem very future-proof. Any additional interdependency of settings will cause unexpected behavior with this approach to user settings. |
steadfasterX
commented
Dec 5, 2024
exactly how it was intended and how I use it |
The motivation here is to remove the steps of the build process which involve editing in-tree files (init.sh and Generate_Signing_Keys.sh), which complicates updates.