Conversation
Owner
Author
|
Sure, but it will take some time because I'm out of office. Please note that fsync() is not working on many ARM platforms (probably RPi too) and the code will generate an error during execution. I my case it was intended to discard the queue to avoid a resend of invalid valid data and hitting a timeout. But I see that this solution was bogus for your platform. |
Owner
|
Can you please give some pointers documenting that fsync is not working on ARM!? What is the exact error message? However, the best we can probably do is to test if the platform has a working fsync during configure (cmake) and ifdef out the calls to fsync otherwise... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes for Arch ARM and documenation changes