Skip to content

Pylama - #495

Merged
DonJayamanne merged 2 commits into
DonJayamanne:masterfrom
tdamsma:pylama
Nov 8, 2016
Merged

Pylama#495
DonJayamanne merged 2 commits into
DonJayamanne:masterfrom
tdamsma:pylama

Conversation

@tdamsma

@tdamsma tdamsma commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

I tried to implement pylama (as requested here) in a similar way as pep8. Unfortunately I can't get the current master to build on my system, so I haven't been able to test if it actually works

@DonJayamanne

Copy link
Copy Markdown
Owner

@tdamsma
You need to define the configuration settings in package.json as follows:

        "python.linting.pylamaEnabled": {
          "type": "boolean",
          "default": true,
          "description": "Whether to lint Python files using pylama."
        },
        "python.linting.pylamaPath": {
          "type": "string",
          "default": "pylama",
          "description": "Path to pylama, you can use a custom version of pylama by modifying this setting to include the full path."
        },
        "python.linting.pylamaArgs": {
          "type": "array",
          "description": "Arguments passed in. Each argument is a separate item in the array.",
          "default": [],
          "items": {
            "type": "string"
          }
        },

@DonJayamanne

Copy link
Copy Markdown
Owner

Please try to add some tests for the new linter in the test directory.
FYI - You'll need to update requirements.txt for tests to run on travis

@DonJayamanne
DonJayamanne merged commit c9cc9df into DonJayamanne:master Nov 8, 2016
@tdamsma

tdamsma commented Nov 8, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for accepting the PR, but I didn't have the chance to implement your suggestions. Should I put them in a new PR, or did you already fix it?

@DonJayamanne

Copy link
Copy Markdown
Owner

I made the necessary changes, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants