Pylama - #495
Merged
Merged
Pylama#495
Conversation
Owner
|
@tdamsma "python.linting.pylamaEnabled": {
"type": "boolean",
"default": true,
"description": "Whether to lint Python files using pylama."
},
"python.linting.pylamaPath": {
"type": "string",
"default": "pylama",
"description": "Path to pylama, you can use a custom version of pylama by modifying this setting to include the full path."
},
"python.linting.pylamaArgs": {
"type": "array",
"description": "Arguments passed in. Each argument is a separate item in the array.",
"default": [],
"items": {
"type": "string"
}
}, |
Owner
|
Please try to add some tests for the new linter in the |
Contributor
Author
|
Thanks for accepting the PR, but I didn't have the chance to implement your suggestions. Should I put them in a new PR, or did you already fix it? |
Owner
|
I made the necessary changes, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to implement pylama (as requested here) in a similar way as pep8. Unfortunately I can't get the current master to build on my system, so I haven't been able to test if it actually works