refactor(core): move lifecycle provider-binding into Core-internal - #723
Merged
Conversation
Relocate provider-binding and provider-evidence under src/core/lifecycle/ so Core no longer reverse-depends on src/lifecycle for those helpers. Keep them unpublished from the SDK; state still imports only the model leaf.
Drswith
marked this pull request as ready for review
September 7, 2026 04:14
This was referenced Sep 7, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Sync accepted L2 provider-binding deltas into living specs after #723, and drop the completed change from the working tree without committing the generated archive directory.
cursor Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Sync accepted L2 provider-binding deltas into living specs after #723, and drop the completed change from the working tree without committing the generated archive directory.
Drswith
added a commit
that referenced
this pull request
Sep 7, 2026
* chore(openspec): archive lifecycle-provider-core-internal-l2 Sync accepted L2 provider-binding deltas into living specs after #723, and drop the completed change from the working tree without committing the generated archive directory. * chore(openspec): hang L2 archive KEEP on lifecycle barrel Retarget the product-path keep comment to src/lifecycle/index.ts and revert keep-only churn on src/core/lifecycle/uninstall-postcondition.ts. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
L2 lifecycle internalization: move provider-binding resolution and
observeLifecycleProviderfromsrc/lifecycleinto Core-internal modules atsrc/core/lifecycle/provider-binding.tsandsrc/core/lifecycle/provider-evidence.ts. This removes the next Core →src/lifecyclereverse dependency after L1 without expanding the published SDK.Unlike the L1 model leaf, these modules are not zero-import: they may import agents, provider types, the model leaf, and type-only state. ADR 0012 records that
src/statestill may import only the model leaf. Remainingsrc/lifecycle/*engines stay in place for L3+.Before / after import map
src/core/installation-*.ts../lifecycle/provider-binding./lifecycle/provider-bindingsrc/core/production-observation.ts../lifecycle/provider-binding./lifecycle/provider-bindingsrc/core/update-production.ts../lifecycle/provider-binding./lifecycle/provider-bindingsrc/core/uninstall-executor.ts../lifecyclebarrel./lifecycle/provider-bindingand./lifecycle/provider-evidencesrc/core/client.ts../lifecycle/provider-evidence./lifecycle/provider-bindingsrc/commands/core-installation-cli.ts../lifecycle/provider-binding../core/lifecycle/provider-bindingsrc/services/lifecycle-*.ts../lifecycle/provider-bindingorprovider-evidence../core/lifecycle/provider-bindingsrc/lifecycle/agent-observation.ts./provider-binding../core/lifecycle/provider-bindingsrc/lifecycle/index.tsbarrel./provider-evidencesrc/lifecycle/provider-binding/provider-evidencesrc/core/lifecycle/provider-binding/provider-evidenceUnchanged for L3+: Core still imports agent-observation, update-planner, agent-execution, uninstall-postcondition, and the barrel.
SDK non-export checklist
src/core/index.tsdoes not exportLifecycleProviderBinding,observeLifecycleProvider,resolveInstallMethodProviderBinding, or./lifecyclepackages/core/src/index.tsdoes not export those symbolscreateQuantexonly (test/core/import-purity.test.ts)packages/coreexport subpathsrc/core/lifecycle/index.tsbarrelsrc/lifecyclebarrelFreeze checklist
--json/ NDJSON still omitengine/routerelease-core.yml/ protect-main untouchedrelease-one-line-delivery,release-pr-skip-human-heuristics,windows-ci-advisory-merge-gatesrc/lifecycle/*)lifecycle-model-core-internal-l1)Linked Artifacts
lifecycle-provider-core-internal-l2docs/adr/0012-core-internal-lifecycle-provider-binding.mdValidation
bun run memory:checkbun run lintbun run format:checkbun run typecheckbun run test— 176 files / 2144 passed / 5 skippedbun run openspec:validateinstall/ensure --dry-run --json→ok=true,warnings[0].code=DRY_RUN,data.changed=false, exit0, noengine/route["createQuantex"]Release Intent
refactor:/ Internal Improvements and does not bump on its own.Release Summary
BEGIN_COMMIT_OVERRIDE
refactor(core): move lifecycle provider-binding into Core-internal
END_COMMIT_OVERRIDE
Docs Updated
openspec/changes/lifecycle-provider-core-internal-l2/docs/adr/0012-core-internal-lifecycle-provider-binding.mdAGENTS.md(thin pointer to provider-binding and ADR 0012)Scope Check
Closure Check
lifecycle-provider-core-internal-l2is still active until this merge, then queued for agent-driven archive closure.Notes
src/lifecycle/provider-binding.tsandprovider-evidence.tsabsent;src/core/lifecycle/containsmodel.ts,provider-binding.ts,provider-evidence.tsand noindex.ts;src/stateCore imports remain leaf-only.