fix: show provider version when agent --version probe fails - #738
Merged
Conversation
…be fails Record the list/inspect/doctor display contract for PATH-present agents whose version probe fails but the package provider already reports a version. Co-authored-by: Drswith <Drswith@users.noreply.github.com>
Project installedVersion from the merged executable observation so qtx ls, inspect, and doctor display the provider-reported package version when PATH is present but the live --version probe yields none. Fixes#734 Co-authored-by: Drswith <Drswith@users.noreply.github.com>
…mplete Co-authored-by: Drswith <Drswith@users.noreply.github.com>
Drswith
marked this pull request as ready for review
September 8, 2026 15:39
Uh oh!
There was an error while loading. Please reload this page.
13 tasks
Drswith added a commit
that referenced
this pull request
Sep 8, 2026
Sync accepted agent-version-probing deltas into living specs after #738, and drop the completed change from the working tree without committing the generated archive directory. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an agent's
--versionprobe fails (non-zero exit, crash, or unparseable output),qtx ls/qtx inspect/qtx doctorshowedunknowneven though the lifecycle observation already merged the provider-reported package version ontoexecutable. The v1 inspection projector was reading the raw PATH probe (pathExecutable) forinstalledVersion.This change keeps that projector thin:
installedVersioncomes from the mergedexecutablewhen PATH is present, so a provider-reported version is displayed after a failed--versionprobe.inPath/installedand binary-path fields stay on PATH presence, so a provider-only version does not mark an agent as installed.Fixes#734.
Linked Artifacts
Validation
bun run memory:checkbun run lintbun run format:checkbun run typecheckbun run test(if behavior changed)bun run openspec:validateLocal results: 2191 passed, 5 skipped; OpenSpec 27/27; project memory check passed.
CI matrix on this head: lint, governance, classify, test (ubuntu-latest), test (macos-latest), and test (windows-latest) all passed. Advisory canaries also passed.
Test plan for the reported regression:
--versionprobe empty/failed, provider present+version → projectorinstalledVersionis the provider versionqtx lshuman and JSON show that version, notunknownqtx inspectincludes the Version row and JSONinstalledVersionqtx doctorshows the provider version, notunknowninstalled: falseand omitsinstalledVersionRelease Intent
Release Summary
BEGIN_COMMIT_OVERRIDE
fix: show the provider-reported agent version when --version fails
When an installed agent's --version command crashes or exits non-zero, list, inspect, and doctor showed unknown even though the package manager already knew the installed version. Those commands now display the provider-reported version.
END_COMMIT_OVERRIDE
Docs Updated
openspec/changes/inspect-provider-version-fallback/Scope Check
Closure Check
Notes
Product CI matrix is green. Do not tag a release in this PR; release-please should consume the user-facing patch override after merge. OpenSpec archive closure waits until this implementation PR merges and the change is archive-eligible.
JSON, aliases, exit codes, state v2, and receipts are unchanged.
--jsondoes not expose engine or route. No YAML,release-core.yml, or protect-main edits. No SDK or command expansion. Issues #133, #134, and Release Please #736 were not started.