Uh oh!
There was an error while loading. Please reload this page.
Fetch all source files before processing easystack file - #283
Open
bedroge wants to merge 7 commits into
Open
Conversation
bedroge
commented
Aug 7, 2026
ContributorAuthor
This one has tarballs from the GNU mirror, which was causing issues in EESSI/software-layer#1557 bot: build repo:eessi.io-2026.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
bedroge
commented
Aug 7, 2026
ContributorAuthor
bot: build repo:eessi.io-2026.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
New job on instance
|
bedroge
commented
Aug 7, 2026
ContributorAuthor
The a64fx build already showed how this improves things: |
bedroge
commented
Aug 7, 2026
ContributorAuthor
Trying it again with bot: build repo:eessi.io-2026.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
New job on instance
|
bedroge
commented
Aug 7, 2026
ContributorAuthor
Also trying one without the last item ( bot: build repo:eessi.io-2026.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
bedroge
commented
Aug 7, 2026
ContributorAuthor
a64fx build (still with 3 items in the easystack): Then it exits, as expected. For the zen 2 build (only 2 items): So, also as expected. Will do one more without download issues to ensure that this still works as well. |
bedroge
commented
Aug 7, 2026
ContributorAuthor
bot: build repo:eessi.io-2026.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
New job on instance
|
bedroge
commented
Aug 7, 2026
ContributorAuthor
That still works, so everything seems to work as expected. Removed the easystack file again. Note that this doesn't require a build/ingest. |
boegel
reviewed
Aug 7, 2026
| if [ -f ${easystack_file} ]; then | ||
| echo_green "Downloading sources for easystack file ${easystack_file}..." | ||
| ${EB} --fetch-all --easystack ${easystack_file} --robot |
Contributor
There was a problem hiding this comment.
--fetch-all is only supported from EasyBuild 5.3.0 onwards, do we need a version check here?
ContributorAuthor
There was a problem hiding this comment.
Good point. I guess it's not very likely that we'll still be using older versions, but I've added a check by running eb --help and grepping for --fetch-all first. Otherwise it falls back to --fetch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it fail early in case source tarballs cannot be downloaded. Note that if you're processing multiple easystack files, it will not fetch the sources for all of them. Doing that would require more changes to the code, and we're not doing that very often anyway: almost all PRs change only one easystack file, so this should already be a big improvement.
I'll give it a try with an actual easystack file.