Use org shared Renovate config instead of generic default - #52
Merged
Merged
Conversation
This repo was extending config:recommended instead of the org's local>EIDU/renovate-config preset used by other EIDU repos, missing grouping rules, review requirements, and vulnerability handling.
The ci.yml job was named Publish despite never publishing anything (it only runs ./gradlew check), colliding with publish.yml's actual Publish job which only fires on tag pushes. The shared name made required-status-check rules bind to the wrong (tag-only) job.
branches: ['*'] does not match branch names containing '/', so CI never ran pre-merge on Renovate's renovate/* branches or any other topic branch (fix/*, feature/*) -- only after merge to main. That made it impossible for any required-status-check rule to work, since the check never appears on the PR. '**' matches slashes too.
Standardizes the name of this repo's required-check-gating job so it can eventually match the same convention across other EIDU repos, letting an org-wide ruleset require one consistent check name instead of enumerating each repo's differently-named job.
Keeps the ci-success id as a stable internal key while giving the check a human-readable display name, which is also the string that required-status-check rules need to reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renovate.jsonfromconfig:recommendedtolocal>EIDU/renovate-config, matching every other EIDU repo (e.g.content-service,gradle-plugins,entity-service).minimumReleaseAge, required reviewers, and vulnerability-alert handling that come from the shared preset.Test plan
./gradlew checkpasses locally