Uh oh!
There was an error while loading. Please reload this page.
Feature: Return Values - #117
Conversation
| String returnType = abi.getActionReturnTypeByActionName(actionTrace.getActionName()); | ||
| AbiEosSerializationObject actionAbiEosSerializationObject = new AbiEosSerializationObject( | ||
| actionTrace.getAccountName(), actionTrace.getActionName(), |
There was a problem hiding this comment.
Do we want to consider constructor overloading here for AbiEosSerializationObject since the account name and action name are not required?
There was a problem hiding this comment.
Yeah, I can add that. My initial concern was that there was some hidden business logic that didn't allow for null account/action names. I just ran a test on the abieos side and it looks like it works. I'll also update EOSIO/eosio-java-android-abieos-serialization-provider#51 with explicit tests for this. The current tests don't pass in null for those fields.
There was a problem hiding this comment.
New tests:
- https://github.com/EOSIO/eosio-java-android-abieos-serialization-provider/pull/51/files#diff-640ac0a6426edefb132dbf8b87d3b6beR188
- https://github.com/EOSIO/eosio-java-android-abieos-serialization-provider/pull/51/files#diff-640ac0a6426edefb132dbf8b87d3b6beR209
- https://github.com/EOSIO/eosio-java-android-abieos-serialization-provider/pull/51/files#diff-640ac0a6426edefb132dbf8b87d3b6beR315
- https://github.com/EOSIO/eosio-java-android-abieos-serialization-provider/pull/51/files#diff-640ac0a6426edefb132dbf8b87d3b6beR336
There was a problem hiding this comment.
@GonnaGitYou Updated in 15bb0b3 and 6743977. Was going to make the main constructor private, but that ends up being a breaking change.
https://blockone.atlassian.net/browse/BLU-2042