You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good find on dead.letter. It must be mine but I don't know how it got there!
The fix looks fine to me. Another option is to remove expontest.cc altogether as it is really a sanity check on the Hankel transform and has doesn't add any functionality to any EXP-based work flow.
Yes, I was also wondering if expontest.cc could just be removed. It could potentially be helpful in a force-accuracy test for Cylinder as well, right? In which case it might make sense to keep it.
It is a standalone example for the PotRZ class (which makes a 3d gravitational potential from a 2d polar density) using the underlying QDHT Hankel transform class. So, yes, perhaps it's worth keeping as a usage case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this in the recent merge of #101: the cylindrical Bessel function issue bit me again on Mac.
Also one piece of cruft can be removed.