Uh oh!
There was an error while loading. Please reload this page.
Velocity field bug fixes - #82
Merged
Merged
Conversation
added 2 commits
July 13, 2024 10:16
…x typo in output message string
…ts; needed to set coefficient arrays from pyEXP
michael-petersen
approved these changes
Aug 8, 2024
michael-petersen
left a comment
Member
There was a problem hiding this comment.
Nice fixes and good compatibility addition for Eigen Tensors.
Good to see outfile dumping to outdir... would be good to check other outputs for consistency at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of minor bug fixes
SphFldStructandCylFldStructconstructors. Should be:Nfld, a configurable parameter.SphFldStructandCylFldStruct.I have tested this in pyEXP but it needs more exercise.