Uh oh!
There was an error while loading. Please reload this page.
Allow accumulators to be fully collapsed - #4
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
jtcoolen added a commit
that referenced
this pull request
Aug 13, 2026
…it-trail truth Closes the documentation and reproducibility findings of the 2026-08 review (M-5, I-1..I-4, TA triage; tracker updated in FIXES_APPLIED_2026-08.md): - install_pinned_solc.sh: real official SHA-256 pins for solc 0.8.30+commit.73712a01 (linux-amd64, macosx-amd64), verified by a live download; fixed a latent bash-3.2 incompatibility (declare -A) that broke the script on stock macOS; Rosetta mapping documented. - New scripts/record_srs_provenance.sh + REPRODUCIBLE_BUILDS.md "SRS Provenance": asset hashes recorded and verified byte-identical against the Midnight trusted-setup ceremony's official MIDNIGHT_SRS_CATALOG.md (github.com/midnightntwrk/midnight-trusted-setup) — the non-code half of H-1. Ceremony citation flagged for deployment-owner confirmation. - New scripts/generate_artifact_manifest.sh produces the REVIEW_PACKET §4 manifest rows per fixture dump; --optimize-runs added to every recorded flag list with the runs=100000-undeployable warning; the three provenance stamps labeled by what they index (canonical table in REPRODUCIBLE_BUILDS.md "Provenance Identities"). - src/codegen/* path sweep: living reviewer docs rewritten to the current src/lowering tree; AUDIT.md / AUDIT_FINDINGS.md carry a path-migration map instead of rewritten history; AUDIT_FINDINGS #4 now cites validators and tests that actually exist. - TA-1..TA-8 triaged with Status lines (TA-1 fixed — the quoted scalar-0 skip no longer exists; TA-5/TA-6 fixed by 460a666; TA-7's fail-closed zero-denominator semantics now specified in the spec). - Spec/mapping docs updated for the exact gas bounds; the spec's supported-target section now states the schedule requirement and the deploy-time fail-fast on repriced chains. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully collapses
Accumulators (off-circuit) andAssignedAccumulators (in-circuit) into a pair of points suitable for a final pairing check.