[auto] reflect: narrow-the-scope names the shared-premise step when one gate rejects twice - #289
Conversation
…ne gate rejects twice Add one sentence to the method: when the same gate rejects a second edited version, write down the one-sentence premise both edits shared, then read the gate's source before a third edit. In two read-confirmed Invoker sessions the agent only escaped a three-attempt loop by reading the gate's own source (a body-keyword checker that scanned the whole PR body; a UNIT_PATTERNS regex), and the shared premise was never written down. The fires_example fixture gains a matching scenario so the prose-only skill's coverage tracks the new trigger. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014NSMiMsTPuon8otdhRaJEq Change-Id: Id0706777811cc493b05bb45ec8a42b8f1a81fb9c
EdbertChan
commented
Sep 8, 2026
OwnerAuthor
This pull request is part of a Mergify stack:
|
9 tasks
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e8a3e704-efeb-4d59-8341-257bd808c366) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The narrow-the-scope skill gains one method sentence: when one gate rejects a second edit, write down the premise both edits shared, then read the gate's source before a third.
The skill's fires_example fixture gains a matching scenario, which the skill test coverage gate requires for a prose-only skill change.
Review Claim
The new sentence names the missing step that ended two real three-attempt loops, in the file's existing tone, without changing any trigger.
Review Lane
behavior
Review Unit
product-skill
Safety Invariant
One sentence added to an existing numbered step and one fixture paragraph; no hook, install path, or trigger condition changes, so nothing fires differently.
Assumptions: headless mode, Safety Invariant is unconfirmed by a human.
Slice Rationale
Evidence: in two read-confirmed Invoker sessions the agent only escaped a three-attempt loop by reading the gate's own source (a body-keyword checker that scanned the whole PR body; a UNIT_PATTERNS regex), and the shared premise was never written down.
This is the prose item from the same reflect pass as the stack's first PR (corpus_scan fix). It is a different Review Unit, so it lands as its own PR on top.
Non-goals
engine/hooks/narrow-the-scope/.Test Plan
Test Plan
python3 scripts/check_skill_test_coverage.py --base origin/main --head HEAD->ok skill test coveragepython3 engine/skills/make-pr/scripts/preflight.py --base origin/main->ok preflight passed(codify-has-code, no-dated-provenance, three-harness, ecosystem-boundaries, skill-file-refs, skill-test-coverage, skill-trigger-mechanism allok)python3 scripts/check_no_dated_provenance.py --base origin/main->ok no dated provenancebash scripts/run_all_tests.sh-> exit 0 (31 suites OK)Revert Plan
Revert Plan
git revert a30b78aDepends-On: #288
🤖 Generated with Claude Code
https://claude.ai/code/session_014NSMiMsTPuon8otdhRaJEq