Uh oh!
There was an error while loading. Please reload this page.
Dev do not pass nondirs to psalm - #123
Closed
flavius wants to merge 3 commits into
Closed
Conversation
Member
How about adding composer to .phpqa.yml? |
zdenekdrahos added a commit
that referenced
this pull request
Mar 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When analyzing a dir
src/, phpmetrics does not detectcomposer.json(which is ok, since the file is in the directory above,src/../.However, phpmetrics can be easily fooled to take composer.json into account, by specifying it in
analyzeDirs- which is not clean, but it works (WORKAROUND - as mentioned later in this comment).But when you do that, psalm fails, because it blindly takes everything which is not a dir into its own configuration.
This PR fixes psalm to make the workaround described above possible.
It's a clean fix, regardless of that fact that the workaround is a hack, because the generated psalm xml config is semantically correct with this patch applied:
<directory ...are indeed directories.