Skip to content

Improve Effect.retry/repeat options - #1793

Merged
mikearnaldi merged 7 commits into
next-minorfrom
feat/new-retry
Jan 14, 2024
Merged

Improve Effect.retry/repeat options#1793
mikearnaldi merged 7 commits into
next-minorfrom
feat/new-retry

Conversation

@mikearnaldi

@mikearnaldimikearnaldi commented Dec 28, 2023

Copy link
Copy Markdown
Member

Missing:

  • tests
  • type tests
  • removal of variants

@changeset-bot

changeset-botBot commented Dec 28, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9f237ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
effectMinor
@effect/platformMajor
@effect/cliMajor
@effect/experimentalMajor
@effect/opentelemetryMajor
@effect/platform-browserMajor
@effect/platform-bunMajor
@effect/platform-nodeMajor
@effect/printer-ansiMajor
@effect/printerMajor
@effect/rpc-http-nodeMajor
@effect/rpc-httpMajor
@effect/rpc-nextjsMajor
@effect/rpc-workersMajor
@effect/rpcMajor
@effect/schemaMajor
@effect/typeclassMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
github-actionsBot changed the base branch from main to next-minorDecember 28, 2023 10:58
@tim-smart
tim-smart changed the base branch from next-minor to mainJanuary 8, 2024 23:28
@github-actions
github-actionsBot changed the base branch from main to next-minorJanuary 8, 2024 23:28
@tim-smarttim-smart changed the title Improve Effect.retry optionsImprove Effect.retry/repeat optionsJan 8, 2024
@tim-smart
tim-smart marked this pull request as ready for review January 9, 2024 00:37
@mikearnaldi
mikearnaldi deleted the branch next-minorJanuary 9, 2024 12:49
@fubhyfubhy reopened this Jan 9, 2024

@tim-smarttim-smart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikearnaldi ready for a review

})
),
Effect.repeatUntil(Option.isSome),
Effect.repeat({ until: (_): _ is Option.Some<OutDone> => Option.isSome(_) }),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a case where tacit usage of refinements can no longer be applied, but maybe this ok.

@mikearnaldi
mikearnaldi merged commit 9a513c5 into next-minorJan 14, 2024
@mikearnaldi
mikearnaldi deleted the feat/new-retry branch January 14, 2024 16:53
@github-actionsgithub-actionsBot mentioned this pull request Jan 14, 2024
github-actionsBot pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actionsBot pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actionsBot pushed a commit that referenced this pull request Jan 15, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actionsBot pushed a commit that referenced this pull request Jan 15, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actionsBot pushed a commit that referenced this pull request Jan 15, 2024
Co-authored-by: Tim <hello@timsmart.co>
pullBot pushed a commit to jessekelly881/effect that referenced this pull request Jul 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mikearnaldi@tim-smart@fubhy