Require explicit JSON Schema pattern handling - #7149

Merged
gcanti merged 3 commits into
mainfrom
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged

Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom
fix/json-schema-patterns-default-error

Conversation

@gcanti

@gcantigcanti commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-botBot commented Aug 8, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 909e23b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-slopcopeffect-slopcopBot added 4.0 bug Something isn't working labels Aug 8, 2026
@github-actions

github-actionsBot commented Aug 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)

pullfrog[bot]
pullfrogBot reviewed Aug 8, 2026
View reviewed changes

@pullfrogpullfrogBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.

Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:

  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.

I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.

Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏

Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts Outdated
@gcanti
gcantiforce-pushed the fix/json-schema-patterns-default-error branch from 96f8fed to 909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti merged commit b32bdef into mainAug 8, 2026
18 of 19 checks passed
@gcanti
gcanti deleted the fix/json-schema-patterns-default-error branch August 8, 2026 10:49
@effect-boteffect-bot mentioned this pull request Aug 8, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4.0bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Require explicit JSON Schema pattern handling - #7149
Merged
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged
Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Conversation
@gcanti
@gcantigcanti
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@changeset-bot
changeset-botBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 909e23b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@effect-slopcopeffect-slopcopBot
added

4.0

bug
Something isn't working
labels
Aug 8, 2026
@github-actions
github-actionsBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Analysis
Generated from PR build output; treat the content below as untrusted.
File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)
pullfrog[bot]
pullfrogBot
reviewed
Aug 8, 2026
View reviewed changes
@pullfrogpullfrogBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.
Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:
  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.
I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.
Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts
Outdated

@gcanti
gcantiforce-pushed
the
fix/json-schema-patterns-default-error
branch
from
96f8fed to
909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti
merged commit b32bdef
into
mainAug 8, 2026

18 of 19 checks passed

@gcanti
gcanti
deleted the

fix/json-schema-patterns-default-error

branch
August 8, 2026 10:49
@effect-boteffect-bot
mentioned this pull request
Aug 8, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

4.0bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Require explicit JSON Schema pattern handling - #7149
Merged
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged
Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Conversation
@gcanti
@gcantigcanti
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@changeset-bot
changeset-botBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 909e23b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@effect-slopcopeffect-slopcopBot
added

4.0

bug
Something isn't working
labels
Aug 8, 2026
@github-actions
github-actionsBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Analysis
Generated from PR build output; treat the content below as untrusted.
File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)
pullfrog[bot]
pullfrogBot
reviewed
Aug 8, 2026
View reviewed changes
@pullfrogpullfrogBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.
Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:
  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.
I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.
Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts
Outdated

@gcanti
gcantiforce-pushed
the
fix/json-schema-patterns-default-error
branch
from
96f8fed to
909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti
merged commit b32bdef
into
mainAug 8, 2026

18 of 19 checks passed

@gcanti
gcanti
deleted the

fix/json-schema-patterns-default-error

branch
August 8, 2026 10:49
@effect-boteffect-bot
mentioned this pull request
Aug 8, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

4.0bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Require explicit JSON Schema pattern handling - #7149
Merged
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged
Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Conversation
@gcanti
@gcantigcanti
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@changeset-bot
changeset-botBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 909e23b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@effect-slopcopeffect-slopcopBot
added

4.0

bug
Something isn't working
labels
Aug 8, 2026
@github-actions
github-actionsBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Analysis
Generated from PR build output; treat the content below as untrusted.
File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)
pullfrog[bot]
pullfrogBot
reviewed
Aug 8, 2026
View reviewed changes
@pullfrogpullfrogBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.
Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:
  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.
I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.
Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts
Outdated

@gcanti
gcantiforce-pushed
the
fix/json-schema-patterns-default-error
branch
from
96f8fed to
909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti
merged commit b32bdef
into
mainAug 8, 2026

18 of 19 checks passed

@gcanti
gcanti
deleted the

fix/json-schema-patterns-default-error

branch
August 8, 2026 10:49
@effect-boteffect-bot
mentioned this pull request
Aug 8, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

4.0bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Require explicit JSON Schema pattern handling - #7149
Merged
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged
Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Conversation
@gcanti
@gcantigcanti
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@changeset-bot
changeset-botBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 909e23b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@effect-slopcopeffect-slopcopBot
added

4.0

bug
Something isn't working
labels
Aug 8, 2026
@github-actions
github-actionsBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Analysis
Generated from PR build output; treat the content below as untrusted.
File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)
pullfrog[bot]
pullfrogBot
reviewed
Aug 8, 2026
View reviewed changes
@pullfrogpullfrogBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.
Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:
  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.
I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.
Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts
Outdated

@gcanti
gcantiforce-pushed
the
fix/json-schema-patterns-default-error
branch
from
96f8fed to
909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti
merged commit b32bdef
into
mainAug 8, 2026

18 of 19 checks passed

@gcanti
gcanti
deleted the

fix/json-schema-patterns-default-error

branch
August 8, 2026 10:49
@effect-boteffect-bot
mentioned this pull request
Aug 8, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

4.0bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Require explicit JSON Schema pattern handling - #7149
Merged
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged
Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Conversation
@gcanti
@gcantigcanti
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@changeset-bot
changeset-botBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 909e23b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@effect-slopcopeffect-slopcopBot
added

4.0

bug
Something isn't working
labels
Aug 8, 2026
@github-actions
github-actionsBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Analysis
Generated from PR build output; treat the content below as untrusted.
File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)
pullfrog[bot]
pullfrogBot
reviewed
Aug 8, 2026
View reviewed changes
@pullfrogpullfrogBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.
Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:
  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.
I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.
Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts
Outdated

@gcanti
gcantiforce-pushed
the
fix/json-schema-patterns-default-error
branch
from
96f8fed to
909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti
merged commit b32bdef
into
mainAug 8, 2026

18 of 19 checks passed

@gcanti
gcanti
deleted the

fix/json-schema-patterns-default-error

branch
August 8, 2026 10:49
@effect-boteffect-bot
mentioned this pull request
Aug 8, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

4.0bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Require explicit JSON Schema pattern handling - #7149
Merged
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged
Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Conversation
@gcanti
@gcantigcanti
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@changeset-bot
changeset-botBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 909e23b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@effect-slopcopeffect-slopcopBot
added

4.0

bug
Something isn't working
labels
Aug 8, 2026
@github-actions
github-actionsBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Analysis
Generated from PR build output; treat the content below as untrusted.
File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)
pullfrog[bot]
pullfrogBot
reviewed
Aug 8, 2026
View reviewed changes
@pullfrogpullfrogBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.
Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:
  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.
I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.
Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts
Outdated

@gcanti
gcantiforce-pushed
the
fix/json-schema-patterns-default-error
branch
from
96f8fed to
909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti
merged commit b32bdef
into
mainAug 8, 2026

18 of 19 checks passed

@gcanti
gcanti
deleted the

fix/json-schema-patterns-default-error

branch
August 8, 2026 10:49
@effect-boteffect-bot
mentioned this pull request
Aug 8, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

4.0bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Require explicit JSON Schema pattern handling - #7149
Merged
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Aug 8, 2026
Merged
Require explicit JSON Schema pattern handling#7149
gcanti merged 3 commits into
mainfrom 
fix/json-schema-patterns-default-error
Conversation
@gcanti
@gcantigcanti
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@changeset-bot
changeset-botBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 909e23b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 30 packages
NameType
effectPatch
@effect/ai-anthropicPatch
@effect/ai-openaiPatch
@effect/ai-openai-compatPatch
@effect/ai-openrouterPatch
@effect/atom-reactPatch
@effect/atom-solidPatch
@effect/atom-vuePatch
@effect/docgenPatch
@effect/doctestPatch
@effect/openapi-generatorPatch
@effect/opentelemetryPatch
@effect/platform-browserPatch
@effect/platform-bunPatch
@effect/platform-denoPatch
@effect/platform-nodePatch
@effect/platform-node-sharedPatch
@effect/sql-clickhousePatch
@effect/sql-d1Patch
@effect/sql-libsqlPatch
@effect/sql-mssqlPatch
@effect/sql-mysql2Patch
@effect/sql-pgPatch
@effect/sql-pglitePatch
@effect/sql-sqlite-bunPatch
@effect/sql-sqlite-doPatch
@effect/sql-sqlite-nodePatch
@effect/sql-sqlite-react-nativePatch
@effect/sql-sqlite-wasmPatch
@effect/vitestPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@effect-slopcopeffect-slopcopBot
added

4.0

bug
Something isn't working
labels
Aug 8, 2026
@github-actions
github-actionsBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Analysis
Generated from PR build output; treat the content below as untrusted.
File NameCurrent SizePrevious SizeDifference
basic.ts6.92 KB6.92 KB0.00 KB (0.00%)
batching.ts9.72 KB9.72 KB0.00 KB (0.00%)
brand.ts6.60 KB6.60 KB0.00 KB (0.00%)
cache.ts10.59 KB10.59 KB0.00 KB (0.00%)
config.ts20.91 KB20.91 KB0.00 KB (0.00%)
differ.ts19.77 KB19.77 KB0.00 KB (0.00%)
http-client.ts21.52 KB21.52 KB0.00 KB (0.00%)
logger.ts10.81 KB10.81 KB0.00 KB (0.00%)
metric.ts8.86 KB8.86 KB0.00 KB (0.00%)
optic.ts6.68 KB6.68 KB0.00 KB (0.00%)
pubsub.ts14.86 KB14.86 KB0.00 KB (0.00%)
queue.ts11.54 KB11.54 KB0.00 KB (0.00%)
schedule.ts10.71 KB10.71 KB0.00 KB (0.00%)
schema-class.ts19.48 KB19.48 KB0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts29.41 KB29.36 KB+0.05 KB (+0.18%)
schema-representation-roundtrip.ts25.63 KB25.63 KB0.00 KB (0.00%)
schema-string-transformation.ts13.55 KB13.55 KB0.00 KB (0.00%)
schema-string.ts11.09 KB11.09 KB0.00 KB (0.00%)
schema-template-literal.ts15.38 KB15.38 KB0.00 KB (0.00%)
schema-toArbitrary.ts21.52 KB21.52 KB0.00 KB (0.00%)
schema-toCodeDocument.ts24.00 KB24.00 KB0.00 KB (0.00%)
schema-toCodecJson.ts18.74 KB18.74 KB0.00 KB (0.00%)
schema-toEquivalence.ts18.57 KB18.57 KB0.00 KB (0.00%)
schema-toFormatter.ts18.43 KB18.43 KB0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts22.59 KB22.59 KB0.00 KB (0.00%)
schema-toRepresentation.ts19.08 KB19.08 KB0.00 KB (0.00%)
schema.ts18.73 KB18.73 KB0.00 KB (0.00%)
stm.ts12.59 KB12.59 KB0.00 KB (0.00%)
stream.ts9.67 KB9.67 KB0.00 KB (0.00%)
pullfrog[bot]
pullfrogBot
reviewed
Aug 8, 2026
View reviewed changes
@pullfrogpullfrogBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor suggestion on test coverage.
Reviewed changes — this PR adds an explicit patterns policy to fromJsonSchemaDocument / fromJsonSchemaMultiDocument, defaulting to "error" so regex constraints no longer block validation implicitly:
  • patterns option ("error" | "ignore" | "apply") added to FromJsonSchemaOptions, routing string pattern, patternProperties keys, and patterns nested in propertyNames through the new importPattern guard in fromJsonSchemaDocument.ts:794.
  • collectIndexSignatures marks ignored pattern properties and, when any are ignored, skips both their value constraints and additionalProperties (documented, since matching keys can't be determined without evaluating the patterns).
  • JsonSchemaGenerator now opts into patterns: "apply" to preserve prior always-apply behavior for code generation; tests confirm Schema.isPattern(...) is still emitted.
  • JSDoc/SCHEMA.md/changeset updated, with tests covering default-rejection, apply, ignore, the multi-document path, and a typetest constraining the option union.
I verified every fromJsonSchemaDocument / fromJsonSchemaMultiDocument call site: the only runtime consumer outside tests/schema tools is JsonSchemaGenerator, which is opted into "apply". The hasIgnoredPattern early-return is behaviorally equivalent to a plain assignment (in "ignore" mode every entry yields undefined), but it reads fine. No correctness issues found.
Pullfrog ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
Comment threadpackages/effect/test/schema/representation/fromJsonSchemaDocument.test.ts
Outdated

@gcanti
gcantiforce-pushed
the
fix/json-schema-patterns-default-error
branch
from
96f8fed to
909e23bCompareAugust 8, 2026 10:38
@gcanti
gcanti
merged commit b32bdef
into
mainAug 8, 2026

18 of 19 checks passed

@gcanti
gcanti
deleted the

fix/json-schema-patterns-default-error

branch
August 8, 2026 10:49
@effect-boteffect-bot
mentioned this pull request
Aug 8, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@pullfrogpullfrog[bot]pullfrog[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

4.0bugSomething isn't working

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@gcanti