Uh oh!
There was an error while loading. Please reload this page.
Fix readonly SQLite transactions - #7484
Merged
tim-smart merged 1 commit intoAug 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 05d2b14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Kashkovsky
commented
Aug 26, 2026
ContributorAuthor
@tim-smart, would you mind reviewing this? It narrows the transaction opener introduced in #7162 to preserve |
tim-smart
approved these changes
Aug 26, 2026
tim-smart
enabled auto-merge (squash)
August 26, 2026 21:33
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Uh oh!
There was an error while loading. Please reload this page.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BEGINfor read-only Bun and Node SQLite clientsBEGIN IMMEDIATEfor writable clientsPRAGMA query_only = ONwith read-onlywithTransactioncallsWhy
#7162 changed explicit SQLite transactions to
BEGIN IMMEDIATEto acquire the writer lock up front and avoid read-to-write snapshot upgrade failures. That behavior is correct for writable clients, but it also applied to clients opened withreadonly: true.When a read-only connection enables SQLite's
PRAGMA query_only = ON, evenwithTransaction(SELECT)then fails while opening the transaction becauseBEGIN IMMEDIATErequests a write transaction. Bun reportsSQLITE_READONLY; Node reports SQLite error code 8.This selects the transaction opener from the client's declared access mode. The existing contention tests continue to prove that writable transactions acquire the writer lock immediately.
Closes#7482.