Skip to content

Add e2e_needs_sandbox labeler support for local processor sandbox - #32

Merged
tdesai-eightfold merged 5 commits into
masterfrom
feature/add-needs-local-processor-support
Apr 22, 2026
Merged

Add e2e_needs_sandbox labeler support for local processor sandbox#32
tdesai-eightfold merged 5 commits into
masterfrom
feature/add-needs-local-processor-support

Conversation

@tdesai-eightfold

@tdesai-eightfoldtdesai-eightfold commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds labeler support for the new e2e_needs_sandbox comment form introduced in vscode#100917.

  • e2e_needs_sandbox (and region/time/app variants) now trigger the same sandbox labels as needs_sandbox
  • The e2e_ prefix signals the GitHub bot to start a local processor alongside the sandbox
  • Updated script header to document e2e_needs_sandbox as a supported command

Supported comment forms

CommentLabel added
e2e_needs_sandboxsandbox
e2e_needs_sandbox:eusandbox :eu:
e2e_needs_sandbox:10:taPwasandbox
e2e_needs_sandbox:3.13sandbox:3.13

@github-actions

github-actionsBot commented Apr 22, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@tdesai-eightfoldtdesai-eightfold changed the title _processor support added in needs_sandboxAdd e2e_needs_sandbox labeler support for local processor sandboxApr 22, 2026
@tdesai-eightfold

tdesai-eightfold commented Apr 22, 2026

Copy link
Copy Markdown
ContributorAuthor

Regression Test Results — OLD (master) vs NEW (branch)

Total: 106 | ✅ PASS: 106 | ❌ FAIL: 0

No regressions. All old cases (positive + negative) behave identically on the new branch. Only intentional changes:

  • needs_sandbox:...:_processor no longer matches (dropped — processor now lives on e2e_needs_sandbox)
  • e2e_needs_sandbox variants added with parity to needs_sandbox
Full results table (click to expand)
CommentOLD outputNEW outputStatus
needs_sandboxsandboxsandbox
needs_sandbox sandboxsandbox
needs_sandbox\t (trailing tab)nonenone
needs_sandbox (trailing double space)sandboxsandbox
needs_sandbox:1sandboxsandbox
needs_sandbox:10sandboxsandbox
needs_sandbox:100sandboxsandbox
needs_sandbox:0.5sandboxsandbox
needs_sandbox:1.5sandboxsandbox
needs_sandbox:10.sandboxsandbox
needs_sandbox:devsandboxsandbox
needs_sandbox:taPwasandboxsandbox
needs_sandbox:TAsandboxsandbox
needs_sandbox:app1,app2sandbox :australia:sandbox :australia:
needs_sandbox:10:taPwasandboxsandbox
needs_sandbox:10:taPwa,navBar,getHelpsandboxsandbox
needs_sandbox:dev:taPwasandboxsandbox
needs_sandbox:eusandbox :eu:sandbox :eu:
needs_sandbox:casandbox :maple_leaf:sandbox :maple_leaf:
needs_sandbox:govsandbox :classical_building:sandbox :classical_building:
needs_sandbox:uaesandbox :united_arab_emirates:sandbox :united_arab_emirates:
needs_sandbox:wusandbox :us:sandbox :us:
needs_sandbox:apsandbox :australia:sandbox :australia:
needs_sandbox:eu:10sandbox :eu:sandbox :eu:
needs_sandbox:ca:1.5sandbox :maple_leaf:sandbox :maple_leaf:
needs_sandbox:gov:devsandbox :classical_building:sandbox :classical_building:
needs_sandbox:uae:10:taPwasandbox :united_arab_emirates:sandbox :united_arab_emirates:
needs_sandbox:wu:10:taPwa,navBarsandbox :us:sandbox :us:
needs_sandbox:ap:dev:taPwasandbox :australia:sandbox :australia:
needs_sandbox:eu:taPwasandbox :eu:sandbox :eu:
needs_sandbox:3.13nonenone
needs_sandbox:3.13:eunonenone
needs_sandbox:3.13:canonenone
needs_sandbox:3.13:govnonenone
needs_sandbox:3.13:uaenonenone
needs_sandbox:3.13:wunonenone
needs_sandbox:3.13:apnonenone
needs_sandbox:3.13:10nonenone
needs_sandbox:3.13:devnonenone
needs_sandbox:3.13:eu:10nonenone
needs_sandbox:3.13:eu:10:taPwanonenone
needs_sandbox:3.13:taPwanonenone
needs_sandbox:_processorsandboxnone(intentional)
needs_sandbox:10:_processorsandboxnone(intentional)
needs_sandbox:taPwa:_processorsandboxnone(intentional)
needs_sandbox:eu:_processorsandbox :eu:none(intentional)
needs_sandbox:eu:10:_processorsandbox :eu:none(intentional)
needs_sandbox:eu:10:taPwa:_processorsandbox :eu:none(intentional)
needs_sandbox:ap:dev:_processorsandbox :australia:none(intentional)
needs_sandbox:3.13:_processornonenone
needs_sandbox:3.13:eu:_processornonenone
needs_sandbox:3.13:10:taPwa:_processornonenone
emptynonenone
spacenonenone
needs_sandbononenone
needs_sandboxxnonenone
xneeds_sandboxnonenone
please needs_sandboxnonenone
needs_sandbox extranonenone
needs_sandbox foononenone
needs_sandbox:nonenone
needs_sandbox::nonenone
needs_sandbox:eu:nonenone
needs_sandbox:abc!defnonenone
needs_sandbox:10.5.5nonenone
needs_sandbox:frsandboxsandbox(fr treated as app name)
needs_sandbox:EUsandboxsandbox(uppercase treated as app name)
stop_sandboxnonenone
shipitnonenone
needs_cinonenone
needs_sandbox!nonenone
needs_sandbox.eunonenone
e2e_needs_sandboxnonesandbox(new)
e2e_needs_sandbox nonesandbox(new)
e2e_needs_sandbox:1nonesandbox(new)
e2e_needs_sandbox:10nonesandbox(new)
e2e_needs_sandbox:1.5nonesandbox(new)
e2e_needs_sandbox:devnonesandbox(new)
e2e_needs_sandbox:taPwanonesandbox(new)
e2e_needs_sandbox:10:taPwanonesandbox(new)
e2e_needs_sandbox:10:taPwa,navBarnonesandbox(new)
e2e_needs_sandbox:eunonesandbox :eu:(new)
e2e_needs_sandbox:canonesandbox :maple_leaf:(new)
e2e_needs_sandbox:govnonesandbox :classical_building:(new)
e2e_needs_sandbox:uaenonesandbox :united_arab_emirates:(new)
e2e_needs_sandbox:wunonesandbox :us:(new)
e2e_needs_sandbox:apnonesandbox :australia:(new)
e2e_needs_sandbox:eu:10nonesandbox :eu:(new)
e2e_needs_sandbox:ca:1.5nonesandbox :maple_leaf:(new)
e2e_needs_sandbox:gov:devnonesandbox :classical_building:(new)
e2e_needs_sandbox:uae:10:taPwanonesandbox :united_arab_emirates:(new)
e2e_needs_sandbox:wu:10:taPwa,navBarnonesandbox :us:(new)
e2e_needs_sandbox:ap:dev:taPwanonesandbox :australia:(new)
e2e_needs_sandbox:3.13nonenone
e2e_needs_sandbox:3.13:eunonenone
e2e_needs_sandbox:3.13:10:taPwanonenone
e2e__needs_sandboxnonenone
e2e_needs_sandbononenone
E2E_needs_sandboxnonenone
xe2e_needs_sandboxnonenone
please e2e_needs_sandboxnonenone
e2e_needs_sandbox extranonenone
e2e_needs_sandbox::nonenone
e2e_needs_sandbox:!nonenone
e2e_stop_sandboxnonenone
e2eneeds_sandboxnonenone

Summary

CategoryCountBehavior
Old positives (label unchanged)30Every needs_sandbox form that previously got labelled still gets the same label
Alt-python needs_sandbox:3.13 (no-op since curr==alt)12Matches outer regex but adds no label — same as before
_processor intentional drop7Old added sandbox label, new doesn't — expected per PR
Old negatives (no match)20Every invalid input still rejected
New e2e_needs_sandbox positives21Adds identical labels to needs_sandbox variants
New e2e_needs_sandbox:3.13 (no-op)3Matches but no label, same as needs_sandbox:3.13
New e2e_needs_sandbox negatives10Typos, uppercase, prefixes all correctly rejected
Total106All pass

@tdesai-eightfold
tdesai-eightfold merged commit 5b0df68 into masterApr 22, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tdesai-eightfold@schourasia-2-eightfold