Conversation
- notebooks/02-function-level/18-phase18-large-long.ipynb 신규 - 코드 변경 없음 — Phase 15/16/17 framework 그대로 사용 (scale-up 검증) - Phase 18 config (Phase 17 대비): - hidden_dim: 256 → 512 (2x) - n_heads: 8 → 16 (head_dim=32 유지) - n_layers: 6 → 12 (2x) - ffn_dim (large): 512 → 1024 (2x) - max_steps: 5000 → 15000 (3x) - approx params: ~6.4M → ~30-40M (~5-6x) - 5 mode × 2 seed = 10 run: - dense_large / static_prune_50 / DST_RigL_p16hp (control) / DST_RigL_p17hp / grown - 자동 verdict 4건 + 새 verdict (plateau 도달 검증 — drift < -0.001) - Phase 16/17/18 3단계 progression bar chart (scale-up trend 정량화) - 추정 GPU 시간: 단일 GPU 4-6 시간
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a Phase 18 experimental notebook that scales model size and training length, runs a 5-mode × 2-seed sweep on TinyShakespeare, aggregates results with automated verdicts including plateau detection, visualizes loss curves with event markers, and compares Phase 16/17/18 final losses. ChangesPhase 18 Large-Scale Training Sweep
Sequence Diagram(s)sequenceDiagram
participant Notebook
participant HybridTransformerTrainConfig
participant train_hybrid_transformer_lm
participant RunsStorage
Notebook->>HybridTransformerTrainConfig: build config(mode, seed, DST/grow params)
Notebook->>train_hybrid_transformer_lm: call with config
train_hybrid_transformer_lm->>RunsStorage: save run outputs (losses, metrics, model)
train_hybrid_transformer_lm-->>Notebook: return summary (final loss, params, sparsity)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related issues
Possibly related PRs
Suggested labelsenhancement Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds a new Jupyter notebook for Phase 18 of the neuron experiment, scaling up the model size and training steps to reach a true plateau. The review feedback highlights a logical issue in the plateau verification code, where a positive drift (representing diverging or increasing loss) would incorrectly be marked as a plateau. A bounded check is suggested to resolve this.
There was a problem hiding this comment.
Pull request overview
Phase 17 의 plateau 미도달 한계를 검증하기 위해 더 큰 Transformer 설정과 더 긴 학습 budget 을 적용한 Phase 18 실험 노트북을 추가합니다.
Changes:
- hidden/layer/FFN/step 수를 확대한 5 mode × 2 seed sweep 구성 추가
- all-finite, DST/static, grown/dense, plateau verdict 자동 산출
- Phase 16/17/18 progression 및 loss curve 시각화 추가
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@notebooks/02-function-level/18-phase18-large-long.ipynb`:
- Line 20: The plateau criterion text says "drift < -0.001" but the
implementation checks "mean_drift > -0.001", causing opposite behavior; update
the implementation so the check uses the same relation as the spec (replace
mean_drift > -0.001 with mean_drift < -0.001) or alternatively change the
descriptive text to match the implemented logic—ensure all occurrences of the
plateau test (variables drift, mean_drift and the threshold -0.001) use the same
sign and wording so the verdict is consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9d09d259-7384-4188-9885-c377ab28bfb9
📒 Files selected for processing (1)
notebooks/02-function-level/18-phase18-large-long.ipynb
- gemini/Copilot/CodeRabbit 4 reviews 모두 동일 지적 - 기존 `mean_drift > -0.001` 는 발산 (loss 증가) 도 PASS 처리하는 논리 결함 - 텍스트 (line 20, line 339) 와 구현 (line 354) 이 서로 반대 방향이라 해석 혼란 - 절댓값 기준 통일: |drift| < 0.001 만 plateau, status (plateau / still learning / diverging) 분기 출력 추가
- loss_curves.png: 15K step, 5 mode, mean ± σ over 2 seeds - phase16_17_18_progression.png: scale progression bar chart
연관 이슈
구현 내용
Phase 17 (PR #81) 의 핵심 한계 (plateau 미도달 — 모든 mode drift -0.006) 해소를 위해 larger model (2x) + longer training (3x) 동시 적용. 사용자 명시 방향 반영.
코드 변경 없음
Phase 15/16/17 의 framework 이 모든 config 지원. 본 PR 의 검증 대상은 추가 scale + 시간의 영향 이므로 새 코드 없이 노트북만 추가.
Scale-up (Phase 17 대비)
신규 노트북
notebooks/02-function-level/18-phase18-large-long.ipynbdense_large/static_prune_50/DST_RigL_p16hp(control) /DST_RigL_p17hp/grownCompute 추정
CI / 머지 게이트 점검
변경 영향 범위
notebooks/02-function-level/(1 신규). 코드 / 테스트 변경 없음.Low— 순수 노트북 추가Required Status Checks
롤백 계획
Phase 18 후 시나리오 (사용자 결정 대기)
GPU 사용자 측 실행 후 verdict 분석 → Phase 19 결정.
Summary by CodeRabbit