-
Notifications
You must be signed in to change notification settings - Fork 1
[REFAC#389] fetcher/worker/retry_scheduler → publisher.RetryScheduler 이동 #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
test/internal/processor/fetcher/worker/pool_retry_scheduler_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package worker_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "sync" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/mock" | ||
|
|
||
| "issuetracker/internal/processor/fetcher/worker" | ||
| "issuetracker/internal/publisher" | ||
| "issuetracker/pkg/logger" | ||
| pkgredis "issuetracker/pkg/redis" | ||
| ) | ||
|
|
||
| // poolRetryFakeQueue 는 publisher 측 retryQueueClient 인터페이스를 구조적으로 만족하는 | ||
| // in-memory 더블입니다. pool.SetRetryScheduler 통합 시나리오 전용 (다른 publisher 단위 테스트는 | ||
| // test/internal/publisher/retry_test.go 의 자체 fake 사용). | ||
| type poolRetryFakeQueue struct { | ||
| mu sync.Mutex | ||
| items []poolRetryItem | ||
| } | ||
|
|
||
| type poolRetryItem struct { | ||
| jobID string | ||
| payload []byte | ||
| scheduledAt time.Time | ||
| } | ||
|
|
||
| func newPoolRetryFakeQueue() *poolRetryFakeQueue { return &poolRetryFakeQueue{} } | ||
|
|
||
| func (f *poolRetryFakeQueue) EnqueueRetry(_ context.Context, jobID string, payload []byte, scheduledAt time.Time) error { | ||
| f.mu.Lock() | ||
| defer f.mu.Unlock() | ||
| f.items = append(f.items, poolRetryItem{jobID: jobID, payload: payload, scheduledAt: scheduledAt}) | ||
| return nil | ||
| } | ||
|
|
||
| func (f *poolRetryFakeQueue) PeekDueRetries(_ context.Context, _ time.Time, _ int) ([]pkgredis.DueRetry, error) { | ||
| return nil, nil | ||
| } | ||
|
|
||
| func (f *poolRetryFakeQueue) AckRetry(_ context.Context, _ string) error { return nil } | ||
|
|
||
| func (f *poolRetryFakeQueue) snapshotLen() int { | ||
| f.mu.Lock() | ||
| defer f.mu.Unlock() | ||
| return len(f.items) | ||
| } | ||
|
|
||
| // TestKafkaConsumerPool_SetRetryScheduler_BypassesInlinePublish 는 SetRetryScheduler 로 | ||
| // 주입한 publisher.RetryScheduler 구현체가 호출되어 inline producer.Publish 가 우회됨을 검증. | ||
| func TestKafkaConsumerPool_SetRetryScheduler_BypassesInlinePublish(t *testing.T) { | ||
| consumer := new(mockConsumer) | ||
| producer := new(mockProducer) | ||
| handler := new(mockJobHandler) | ||
| contentSvc := new(mockContentService) | ||
|
|
||
| pool := worker.NewKafkaConsumerPool(consumer, producer, handler, contentSvc, 1) | ||
|
|
||
| q := newPoolRetryFakeQueue() | ||
| customScheduler := publisher.NewRedisDelayedRetryScheduler(q, producer, publisher.RedisRetrySchedulerConfig{ | ||
| PollInterval: time.Hour, | ||
| BatchSize: 1, | ||
| RepublishFailureBackoff: time.Hour, | ||
| }, logger.New(logger.DefaultConfig())) | ||
| pool.SetRetryScheduler(customScheduler) | ||
|
|
||
| job := newTestJob() | ||
| job.RetryCount = 1 | ||
| msg := marshaledJobMsg(t, job) | ||
|
|
||
| handler.On("Handle", mock.Anything, job).Return(nil, errors.New("transient")) | ||
| consumer.On("CommitMessages", mock.Anything, mock.Anything).Return(nil) | ||
|
|
||
| runPool(t, consumer, pool, msg) | ||
|
|
||
| // inline producer.Publish 는 호출되지 않아야 함 — 모든 retry 가 Redis 경로로 | ||
| producer.AssertNotCalled(t, "Publish", mock.Anything, mock.Anything) | ||
| assert.Equal(t, 1, q.snapshotLen(), "주입된 RedisDelayedRetryScheduler 가 enqueue 받았음") | ||
| consumer.AssertCalled(t, "CommitMessages", mock.Anything, mock.Anything) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.