Skip to content

[REFAC#419] parser/worker/parser_worker.go → worker.go + ParserWorker → Worker - #420

Merged
juhy0987 merged 2 commits into
mainfrom
refactor/#419/parser-worker-rename
May 13, 2026
Merged

juhy0987 merged 2 commits into
mainfrom
refactor/#419/parser-worker-rename

Conversation

@juhy0987

Copy link
Copy Markdown
Member

연관 이슈

Closes #419

구현 내용

PR #418 (이슈 #417 stage 패키지 정합화) 후속 — parser 의 주 worker 파일 / 타입명에 남아있던 redundant Parser prefix 정리.

Before / After

Before After
파일 parser_worker.go worker.go
타입 ParserWorker Worker
생성자 NewParserWorker NewWorker

parser/worker 패키지 경로 자체가 "parser worker" 를 표현 — Parser prefix 중복. validate 의 worker.go / Worker / NewWorker 패턴과 일치.

3 stage 비교

stage 주 worker 파일 주 worker 타입
fetcher pool.go KafkaConsumerPool (concept-named, 다중 타입)
parser worker.go (PR 적용 후) Worker
validate worker.go Worker

fetcher 는 pool / semaphore / manager 다중 타입 보유로 concept-named 유지 — 예외.

변경 영향 범위

  • internal/processor/parser/worker/parser_worker.goworker.go (rename)
  • 호출처 5 파일:
    • internal/processor/parser/worker/worker.go (식별자 일괄 치환)
    • internal/processor/parser/stage.go
    • internal/processor/fetcher/worker/pool.go (주석만)
    • cmd/issuetracker/main.go
    • test/internal/processor/parser/worker/{helpers_test.go, stage_gate_test.go}

CI / 머지 게이트 점검

  • gofmt -l — clean
  • go build ./internal/... ./cmd/... ./test/... — pass
  • go test -race -count=1 -timeout=180s ./test/... — 전 패키지 통과 (회귀 0)
  • PR 타이틀 [REFAC#419]
  • commit [REFAC]: prefix + 한국어

변경 영향 범위 + 위험도

  • 영향: 6 파일, +44/-44 라인 (식별자 / 파일명만 변경)
  • 위험도 Low — 순수 명명 정정, 동작 무변경

롤백 계획

PR revert 시 6 파일 동시 원복.

🤖 Generated with Claude Code

…Worker (이슈 #419)

PR #418 (이슈 #417 stage 패키지 정합화) 후속 — parser 의 주 worker 파일 / 타입명에 남아있던
redundant \"Parser\" prefix 정리.

## Before / After

| | Before | After |
|---|---|---|
| 파일 | parser_worker.go | worker.go |
| 타입 | ParserWorker | Worker |
| 생성자 | NewParserWorker | NewWorker |

\"parser/worker\" 패키지 경로 자체가 \"parser worker\" 를 표현 — Parser prefix 중복 제거.
validate 의 worker.go / Worker / NewWorker 패턴과 일치. fetcher 는 pool / semaphore / manager
다중 타입 보유로 concept-named 유지 (예외).

## 변경 영향 범위

- internal/processor/parser/worker/parser_worker.go → worker.go (rename)
- internal/processor/parser/worker/worker.go: 식별자 일괄 치환
- 호출처 5 파일: parser/stage.go, fetcher/worker/pool.go (주석만), cmd/issuetracker/main.go, test 2 개

## 검증

- go build ./internal/... ./cmd/... ./test/... — pass
- go test -race -count=1 -timeout=180s ./test/... — 전 패키지 통과 (회귀 0)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 13, 2026 14:06
@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@juhy0987 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 31 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 23ced841-5e80-4978-8af3-31980ddb1b7c

📥 Commits

Reviewing files that changed from the base of the PR and between b5b7e74 and 79335d4.

📒 Files selected for processing (6)
  • cmd/issuetracker/main.go
  • internal/processor/fetcher/worker/pool.go
  • internal/processor/parser/stage.go
  • internal/processor/parser/worker/worker.go
  • test/internal/processor/parser/worker/helpers_test.go
  • test/internal/processor/parser/worker/stage_gate_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/#419/parser-worker-rename

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@juhy0987 juhy0987 added the refactor Code refactoring label May 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the ParserWorker struct and its constructor to Worker and NewWorker across the codebase to simplify naming conventions. The changes affect the main application logic, the parser stage, and associated tests. The reviewer suggests maintaining naming consistency by also updating variable and parameter names that still use the pw prefix derived from the previous type name.

Comment thread cmd/issuetracker/main.go Outdated
Comment thread internal/processor/parser/stage.go Outdated
gemini 피드백:
- ParserWorker → Worker 로 타입명 변경됨에 따라, 약어 \"pw\" (parser worker) 도 변수명
  일관성을 위해 \"w\" 로 정정.

영향:
- internal/processor/parser/stage.go: NewStage(pw *worker.Worker) 파라미터 + 함수 본문
- cmd/issuetracker/main.go: pw := parserWorker.NewWorker(...) 변수 + 8 곳 참조

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@juhy0987 juhy0987 self-assigned this May 13, 2026
@juhy0987
juhy0987 merged commit 802e4c8 into main May 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] parser/worker 의 parser_worker.go → worker.go + ParserWorker → Worker (#417 follow-up)

2 participants