[REFAC#419] parser/worker/parser_worker.go → worker.go + ParserWorker → Worker - #420
Conversation
…Worker (이슈 #419) PR #418 (이슈 #417 stage 패키지 정합화) 후속 — parser 의 주 worker 파일 / 타입명에 남아있던 redundant \"Parser\" prefix 정리. ## Before / After | | Before | After | |---|---|---| | 파일 | parser_worker.go | worker.go | | 타입 | ParserWorker | Worker | | 생성자 | NewParserWorker | NewWorker | \"parser/worker\" 패키지 경로 자체가 \"parser worker\" 를 표현 — Parser prefix 중복 제거. validate 의 worker.go / Worker / NewWorker 패턴과 일치. fetcher 는 pool / semaphore / manager 다중 타입 보유로 concept-named 유지 (예외). ## 변경 영향 범위 - internal/processor/parser/worker/parser_worker.go → worker.go (rename) - internal/processor/parser/worker/worker.go: 식별자 일괄 치환 - 호출처 5 파일: parser/stage.go, fetcher/worker/pool.go (주석만), cmd/issuetracker/main.go, test 2 개 ## 검증 - go build ./internal/... ./cmd/... ./test/... — pass - go test -race -count=1 -timeout=180s ./test/... — 전 패키지 통과 (회귀 0) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request renames the ParserWorker struct and its constructor to Worker and NewWorker across the codebase to simplify naming conventions. The changes affect the main application logic, the parser stage, and associated tests. The reviewer suggests maintaining naming consistency by also updating variable and parameter names that still use the pw prefix derived from the previous type name.
gemini 피드백: - ParserWorker → Worker 로 타입명 변경됨에 따라, 약어 \"pw\" (parser worker) 도 변수명 일관성을 위해 \"w\" 로 정정. 영향: - internal/processor/parser/stage.go: NewStage(pw *worker.Worker) 파라미터 + 함수 본문 - cmd/issuetracker/main.go: pw := parserWorker.NewWorker(...) 변수 + 8 곳 참조 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
연관 이슈
Closes #419
구현 내용
PR #418 (이슈 #417 stage 패키지 정합화) 후속 — parser 의 주 worker 파일 / 타입명에 남아있던 redundant
Parserprefix 정리.Before / After
parser_worker.goworker.goParserWorkerWorkerNewParserWorkerNewWorkerparser/worker패키지 경로 자체가 "parser worker" 를 표현 —Parserprefix 중복. validate 의worker.go/Worker/NewWorker패턴과 일치.3 stage 비교
pool.goKafkaConsumerPool(concept-named, 다중 타입)worker.go(PR 적용 후)Workerworker.goWorkerfetcher 는 pool / semaphore / manager 다중 타입 보유로 concept-named 유지 — 예외.
변경 영향 범위
internal/processor/parser/worker/parser_worker.go→worker.go(rename)internal/processor/parser/worker/worker.go(식별자 일괄 치환)internal/processor/parser/stage.gointernal/processor/fetcher/worker/pool.go(주석만)cmd/issuetracker/main.gotest/internal/processor/parser/worker/{helpers_test.go, stage_gate_test.go}CI / 머지 게이트 점검
gofmt -l— cleango build ./internal/... ./cmd/... ./test/...— passgo test -race -count=1 -timeout=180s ./test/...— 전 패키지 통과 (회귀 0)[REFAC#419][REFAC]:prefix + 한국어변경 영향 범위 + 위험도
롤백 계획
PR revert 시 6 파일 동시 원복.
🤖 Generated with Claude Code