Uh oh!
There was an error while loading. Please reload this page.
Remove softworkz' special sauce - #928
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the SOFTWORKZ-specific build configuration and consolidates the MSBuild files by inlining the content of ElectronNET.props and ElectronNET.targets directly into their respective .Core counterparts.
Key changes:
- Removed the SOFTWORKZ conditional PropertyGroup from common.props
- Consolidated ElectronNET.props content into ElectronNET.Core.props (removing the indirection)
- Consolidated ElectronNET.targets content into ElectronNET.Core.targets (removing the indirection)
- Updated development mode project references to use the .Core files directly
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common.props | Removed SOFTWORKZ conditional PropertyGroup configuration |
| src/ElectronNET/build/ElectronNET.targets | Deleted file; content moved to ElectronNET.Core.targets |
| src/ElectronNET/build/ElectronNET.props | Deleted file; content moved to ElectronNET.Core.props |
| src/ElectronNET/build/ElectronNET.Core.targets | Replaced Import statement with inline content from ElectronNET.targets |
| src/ElectronNET/build/ElectronNET.Core.props | Replaced Import statement with inline content from ElectronNET.props |
| src/ElectronNET.WebApp/ElectronNET.WebApp.csproj | Updated development mode imports to reference .Core files |
| src/ElectronNET.IntegrationTests/ElectronNET.IntegrationTests.csproj | Updated development mode imports to reference .Core files |
| src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj | Updated development mode imports to reference .Core files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
softworkzforce-pushed
the
submit_remove_priv
branch
from
November 15, 2025 07:44
72ad5e5 to
5305e17CompareFlorianRappl
approved these changes
Nov 15, 2025
FlorianRappl
left a comment
Collaborator
There was a problem hiding this comment.
Great - much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.