Skip to content

Rename PropertyGet to more generic Invocator - #933

Merged
FlorianRappl merged 2 commits into
ElectronNET:developfrom
softworkz:submit_invocation_rename
Nov 15, 2025
Merged

Rename PropertyGet to more generic Invocator#933
FlorianRappl merged 2 commits into
ElectronNET:developfrom
softworkz:submit_invocation_rename

Conversation

@softworkz

Copy link
Copy Markdown
Collaborator

...as it's no longer used for property operations only.

CopilotAI review requested due to automatic review settings November 15, 2025 09:11

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to rename PropertyGetter to the more generic Invocator, reflecting that this component is no longer used exclusively for property operations. The changes update the base API class and propagate through multiple API files.

Key Changes

  • Renamed PropertyGetter class to Invocator in ApiBase.cs
  • Renamed GetPropertyAsync<T>() method to InvokeAsync<T>()
  • Updated all API classes to use this.InvokeAsync<T>() instead of GetPropertyAsync<T>()

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/ElectronNET.API/API/ApiBase.csCore refactoring - renamed base class, methods, fields, and constants from PropertyGetter to Invocator terminology
src/ElectronNET.API/API/WebContents.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/Screen.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/Process.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/Notification.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/NativeTheme.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/Clipboard.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/BrowserWindow.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/BrowserView.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/AutoUpdater.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync
src/ElectronNET.API/API/App.csUpdated method calls to use InvokeAsync instead of GetPropertyAsync

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadsrc/ElectronNET.API/API/ApiBase.cs Outdated
Comment threadsrc/ElectronNET.API/API/ApiBase.cs Outdated
Comment threadsrc/ElectronNET.API/API/ApiBase.cs Outdated
Comment threadsrc/ElectronNET.API/API/ApiBase.cs Outdated
Comment threadsrc/ElectronNET.API/API/ApiBase.cs Outdated
Comment threadsrc/ElectronNET.API/API/ApiBase.cs Outdated
@softworkz
softworkzforce-pushed the submit_invocation_rename branch from 1f496a2 to 0cf1e69CompareNovember 15, 2025 09:17
@softworkz
softworkzforce-pushed the submit_invocation_rename branch from 0cf1e69 to 385dcfbCompareNovember 15, 2025 09:21
@FlorianRapplFlorianRappl added this to the 0.2.0 milestone Nov 15, 2025

@FlorianRapplFlorianRappl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianRappl
FlorianRappl merged commit 7889057 into ElectronNET:developNov 15, 2025
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@softworkz@FlorianRappl