Uh oh!
There was an error while loading. Please reload this page.
Rename PropertyGet to more generic Invocator - #933
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to rename PropertyGetter to the more generic Invocator, reflecting that this component is no longer used exclusively for property operations. The changes update the base API class and propagate through multiple API files.
Key Changes
- Renamed
PropertyGetterclass toInvocatorinApiBase.cs - Renamed
GetPropertyAsync<T>()method toInvokeAsync<T>() - Updated all API classes to use
this.InvokeAsync<T>()instead ofGetPropertyAsync<T>()
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ElectronNET.API/API/ApiBase.cs | Core refactoring - renamed base class, methods, fields, and constants from PropertyGetter to Invocator terminology |
| src/ElectronNET.API/API/WebContents.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Screen.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Process.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Notification.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/NativeTheme.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/Clipboard.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/BrowserWindow.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/BrowserView.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/AutoUpdater.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
| src/ElectronNET.API/API/App.cs | Updated method calls to use InvokeAsync instead of GetPropertyAsync |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
1f496a2 to
0cf1e69Compare0cf1e69 to
385dcfbCompareUh oh!
There was an error while loading. Please reload this page.
...as it's no longer used for property operations only.