Skip to content

ElectronNET.Host: Replace website by a real ts project - #935

Merged
FlorianRappl merged 2 commits into
ElectronNET:developfrom
softworkz:submit_ts_project
Nov 15, 2025
Merged

ElectronNET.Host: Replace website by a real ts project#935
FlorianRappl merged 2 commits into
ElectronNET:developfrom
softworkz:submit_ts_project

Conversation

@softworkz

Copy link
Copy Markdown
Collaborator

That's the last one 😉

CopilotAI review requested due to automatic review settings November 15, 2025 12:15

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates the ElectronNET.Host project from a legacy ASP.NET website project to a modern TypeScript project using the Microsoft.VisualStudio.JavaScript.Sdk. This is the final step in modernizing the ElectronNET infrastructure.

Key changes:

  • Replaces the legacy website project format with an .esproj JavaScript SDK project
  • Updates TypeScript configuration with modern module resolution and compiler options
  • Adds proper type declarations and ambient module definitions for better IDE support

Reviewed Changes

Copilot reviewed 11 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
FileDescription
ElectronNET.slnReplaces old website project with new .esproj JavaScript SDK project; updates Visual Studio version and project dependencies
ElectronNET.WebApp.csprojAdds TypeScript compilation configuration properties
ElectronNET.Host/tsconfig.jsonModernizes TypeScript configuration with updated compiler options and module resolution
ElectronNET.Host/package.jsonUpdates ESLint version and reorganizes dependencies; adds build and clean scripts
ElectronNET.Host/package-lock.jsonUpdates all package dependencies with new versions and license information
ElectronNET.Host/types-shims.d.tsAdds ambient type declarations for external modules to silence TypeScript errors
ElectronNET.Host/globals.d.tsAdds ambient declarations for global variables to improve type safety
ElectronNET.Host/eslint.config.jsAdds ESLint configuration file (placeholder)
ElectronNET.Host/api/ipc.jsRefactors to use optional chaining operator for cleaner code
ElectronNET.Host/ElectronNET.Host.esprojNew JavaScript SDK project file
ElectronNET.Host/.vscode/launch.jsonUpdates debug configuration with improved settings
ElectronNET.Host/ElectronHostHook/*.jsRegenerated JavaScript files with updated source maps and module imports
Files not reviewed (1)
  • src/ElectronNET.Host/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadsrc/ElectronNET.Host/eslint.config.js
Comment threadsrc/ElectronNET.Host/.vscode/launch.json
Comment threadsrc/ElectronNET.WebApp/ElectronNET.WebApp.csproj
Comment threadsrc/ElectronNET.Host/tsconfig.json
@FlorianRappl
FlorianRappl merged commit 90c3eb2 into ElectronNET:developNov 15, 2025
7 checks passed
@FlorianRapplFlorianRappl added this to the 0.2.0 milestone Nov 15, 2025
@FlorianRapplFlorianRappl mentioned this pull request Nov 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@softworkz@FlorianRappl