Uh oh!
There was an error while loading. Please reload this page.
ElectronNET.Host: Replace website by a real ts project - #935
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the ElectronNET.Host project from a legacy ASP.NET website project to a modern TypeScript project using the Microsoft.VisualStudio.JavaScript.Sdk. This is the final step in modernizing the ElectronNET infrastructure.
Key changes:
- Replaces the legacy website project format with an
.esprojJavaScript SDK project - Updates TypeScript configuration with modern module resolution and compiler options
- Adds proper type declarations and ambient module definitions for better IDE support
Reviewed Changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ElectronNET.sln | Replaces old website project with new .esproj JavaScript SDK project; updates Visual Studio version and project dependencies |
| ElectronNET.WebApp.csproj | Adds TypeScript compilation configuration properties |
| ElectronNET.Host/tsconfig.json | Modernizes TypeScript configuration with updated compiler options and module resolution |
| ElectronNET.Host/package.json | Updates ESLint version and reorganizes dependencies; adds build and clean scripts |
| ElectronNET.Host/package-lock.json | Updates all package dependencies with new versions and license information |
| ElectronNET.Host/types-shims.d.ts | Adds ambient type declarations for external modules to silence TypeScript errors |
| ElectronNET.Host/globals.d.ts | Adds ambient declarations for global variables to improve type safety |
| ElectronNET.Host/eslint.config.js | Adds ESLint configuration file (placeholder) |
| ElectronNET.Host/api/ipc.js | Refactors to use optional chaining operator for cleaner code |
| ElectronNET.Host/ElectronNET.Host.esproj | New JavaScript SDK project file |
| ElectronNET.Host/.vscode/launch.json | Updates debug configuration with improved settings |
| ElectronNET.Host/ElectronHostHook/*.js | Regenerated JavaScript files with updated source maps and module imports |
Files not reviewed (1)
- src/ElectronNET.Host/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
That's the last one 😉