Uh oh!
There was an error while loading. Please reload this page.
Wiki Package building macOS sections added - #983
Merged
Conversation
Added profiles for ASP.NET and Console applications on macOS.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds macOS-specific sections to the project's wiki documentation related to package building. The changes include version updates, new migration check targets, expanded test coverage, enhanced API functionality, and comprehensive documentation updates across multiple entity files.
- Version bumped from 0.2.0 to 0.3.0 across the codebase
- Added ElectronNET.MigrationChecks.targets file for build validation
- Enhanced WebContents and Tray APIs with new methods for zoom, audio, DevTools, and user agent management
- Updated numerous entity classes with comprehensive documentation and platform-specific attributes
Reviewed changes
Copilot reviewed 192 out of 194 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/common.props | Version increment to 0.3.0 |
| src/ElectronNET/build/ElectronNET.MigrationChecks.targets | New migration validation checks for build configurations |
| src/ElectronNET/build/ElectronNET.LateImport.targets | Updated electron-builder output directory configuration |
| src/ElectronNET/build/ElectronNET.Core.targets | Imports new migration checks target |
| src/ElectronNET/ElectronNET.csproj | Disabled nullable reference types |
| src/ElectronNET.API/* | Extensive entity documentation updates with platform-specific attributes |
| src/ElectronNET.Host/api/webContents.* | New WebContents methods for zoom, audio, and DevTools |
| src/ElectronNET.IntegrationTests/* | Test refactoring with new base class and enhanced coverage |
Comments suppressed due to low confidence (9)
src/ElectronNET.WebApp/Properties/PublishProfiles/win-x64.pubxml:1
- .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.WebApp/Properties/PublishProfiles/linux-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.WebApp/ElectronNET.WebApp.csproj:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.Samples.ElectronHostHook/ElectronNET.Samples.ElectronHostHook.csproj:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/Properties/PublishProfiles/win-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/Properties/PublishProfiles/publish-win-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/Properties/PublishProfiles/linux-x64.pubxml:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj:1 - .NET 10.0 has not been released as of the knowledge cutoff date (January 2025). The specified target framework version does not exist. Consider using a valid .NET version such as net8.0 or net9.0.
src/ElectronNET.API/API/Entities/PrintOptions.cs:1 - The type of the
Copiesproperty was changed frombooltoint. This is correct per the Electron API documentation, but this is a breaking change that could cause compilation errors in existing code that assigns boolean values to this property.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softworkz
commented
Dec 14, 2025
Collaborator
Should be OK. Thanks for the contribution! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sections for macOS