Disable backtrace on mac - #1258

Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom
conanoc:disable_backtrace
Mar 26, 2018
Merged

Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom
conanoc:disable_backtrace

Conversation

@conanoc

@conanocconanoc commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

fix#840

backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.

The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().

@isghe

isghe commented Mar 22, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

@lvaccaro@gabridome@Sjors
ACK 56ef036

@Sjors

Sjors commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).

@arowser

arowser commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

Running ok on 10.12.4, but if run with lldb, show
`
2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...
2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable
2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host
2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld
2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd
2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd
2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd
2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind
2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd
2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client
2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client
2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13
2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB
Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call
Process 22701 stopped

  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    -> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    0x7fffc80e7d44 <+12>: movq %rax, %rdi
    0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    0x7fffc80e7d4c <+20>: retq
    (lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb)

`

@conanoc

conanoc commented Mar 24, 2018

Copy link
Copy Markdown
ContributorAuthor

yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.

@arowser

arowser commented Mar 25, 2018

Copy link
Copy Markdown
Contributor

Yes, it seems not related, and the issue have been addressed in #1093

@rustyrussell
rustyrussell self-requested a review March 26, 2018 00:29
rustyrussell
rustyrussell approved these changes Mar 26, 2018
View reviewed changes

@rustyrussellrustyrussell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399

ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?

@rustyrussell
rustyrussell merged commit e7c8b95 into ElementsProject:masterMar 26, 2018
@laanwj

laanwj commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().

What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.

So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS

6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Disable backtrace on mac - #1258
Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Mar 26, 2018
Merged
Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Conversation
@conanoc
@conanocconanoc
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
fix#840
backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.
The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
@isghe
isghe
commented
Mar 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
@lvaccaro@gabridome@Sjors

ACK 56ef036
@Sjors
Sjors
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).
@arowser
arowser
commented
Mar 23, 2018

Copy link


Copy Markdown

Contributor
Running ok on 10.12.4, but if run with lldb, show

`

2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...

2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable

2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host

2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld

2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd

2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd

2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd

2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind

2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd

2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client

2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client

2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13

2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB

Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call

Process 22701 stopped
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    
frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    
-> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    
0x7fffc80e7d44 <+12>: movq %rax, %rdi
    
0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    
0x7fffc80e7d4c <+20>: retq
    
(lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT

    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      
frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      
frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      
frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      
frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb) 
`
@conanoc
conanoc
commented
Mar 24, 2018

Copy link


Copy Markdown

ContributorAuthor
yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.
@arowser
arowser
commented
Mar 25, 2018

Copy link


Copy Markdown

Contributor
Yes, it seems not related, and the issue have been addressed in #1093
@rustyrussell
rustyrussell
self-requested a review
March 26, 2018 00:29
rustyrussell
rustyrussell
approved these changes
Mar 26, 2018
View reviewed changes
@rustyrussellrustyrussell
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399
ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?
@rustyrussell
rustyrussell
merged commit e7c8b95
into
ElementsProject:masterMar 26, 2018
@laanwj
laanwj
commented
Mar 26, 2018

Copy link


Copy Markdown

Contributor
The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.
So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS


6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable backtrace on mac - #1258
Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Mar 26, 2018
Merged
Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Conversation
@conanoc
@conanocconanoc
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
fix#840
backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.
The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
@isghe
isghe
commented
Mar 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
@lvaccaro@gabridome@Sjors

ACK 56ef036
@Sjors
Sjors
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).
@arowser
arowser
commented
Mar 23, 2018

Copy link


Copy Markdown

Contributor
Running ok on 10.12.4, but if run with lldb, show

`

2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...

2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable

2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host

2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld

2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd

2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd

2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd

2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind

2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd

2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client

2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client

2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13

2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB

Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call

Process 22701 stopped
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    
frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    
-> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    
0x7fffc80e7d44 <+12>: movq %rax, %rdi
    
0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    
0x7fffc80e7d4c <+20>: retq
    
(lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT

    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      
frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      
frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      
frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      
frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb) 
`
@conanoc
conanoc
commented
Mar 24, 2018

Copy link


Copy Markdown

ContributorAuthor
yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.
@arowser
arowser
commented
Mar 25, 2018

Copy link


Copy Markdown

Contributor
Yes, it seems not related, and the issue have been addressed in #1093
@rustyrussell
rustyrussell
self-requested a review
March 26, 2018 00:29
rustyrussell
rustyrussell
approved these changes
Mar 26, 2018
View reviewed changes
@rustyrussellrustyrussell
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399
ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?
@rustyrussell
rustyrussell
merged commit e7c8b95
into
ElementsProject:masterMar 26, 2018
@laanwj
laanwj
commented
Mar 26, 2018

Copy link


Copy Markdown

Contributor
The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.
So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS


6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable backtrace on mac - #1258
Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Mar 26, 2018
Merged
Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Conversation
@conanoc
@conanocconanoc
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
fix#840
backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.
The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
@isghe
isghe
commented
Mar 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
@lvaccaro@gabridome@Sjors

ACK 56ef036
@Sjors
Sjors
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).
@arowser
arowser
commented
Mar 23, 2018

Copy link


Copy Markdown

Contributor
Running ok on 10.12.4, but if run with lldb, show

`

2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...

2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable

2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host

2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld

2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd

2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd

2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd

2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind

2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd

2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client

2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client

2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13

2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB

Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call

Process 22701 stopped
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    
frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    
-> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    
0x7fffc80e7d44 <+12>: movq %rax, %rdi
    
0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    
0x7fffc80e7d4c <+20>: retq
    
(lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT

    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      
frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      
frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      
frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      
frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb) 
`
@conanoc
conanoc
commented
Mar 24, 2018

Copy link


Copy Markdown

ContributorAuthor
yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.
@arowser
arowser
commented
Mar 25, 2018

Copy link


Copy Markdown

Contributor
Yes, it seems not related, and the issue have been addressed in #1093
@rustyrussell
rustyrussell
self-requested a review
March 26, 2018 00:29
rustyrussell
rustyrussell
approved these changes
Mar 26, 2018
View reviewed changes
@rustyrussellrustyrussell
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399
ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?
@rustyrussell
rustyrussell
merged commit e7c8b95
into
ElementsProject:masterMar 26, 2018
@laanwj
laanwj
commented
Mar 26, 2018

Copy link


Copy Markdown

Contributor
The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.
So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS


6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Disable backtrace on mac - #1258
Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Mar 26, 2018
Merged
Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Conversation
@conanoc
@conanocconanoc
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
fix#840
backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.
The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
@isghe
isghe
commented
Mar 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
@lvaccaro@gabridome@Sjors

ACK 56ef036
@Sjors
Sjors
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).
@arowser
arowser
commented
Mar 23, 2018

Copy link


Copy Markdown

Contributor
Running ok on 10.12.4, but if run with lldb, show

`

2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...

2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable

2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host

2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld

2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd

2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd

2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd

2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind

2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd

2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client

2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client

2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13

2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB

Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call

Process 22701 stopped
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    
frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    
-> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    
0x7fffc80e7d44 <+12>: movq %rax, %rdi
    
0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    
0x7fffc80e7d4c <+20>: retq
    
(lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT

    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      
frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      
frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      
frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      
frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb) 
`
@conanoc
conanoc
commented
Mar 24, 2018

Copy link


Copy Markdown

ContributorAuthor
yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.
@arowser
arowser
commented
Mar 25, 2018

Copy link


Copy Markdown

Contributor
Yes, it seems not related, and the issue have been addressed in #1093
@rustyrussell
rustyrussell
self-requested a review
March 26, 2018 00:29
rustyrussell
rustyrussell
approved these changes
Mar 26, 2018
View reviewed changes
@rustyrussellrustyrussell
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399
ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?
@rustyrussell
rustyrussell
merged commit e7c8b95
into
ElementsProject:masterMar 26, 2018
@laanwj
laanwj
commented
Mar 26, 2018

Copy link


Copy Markdown

Contributor
The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.
So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS


6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable backtrace on mac - #1258
Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Mar 26, 2018
Merged
Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Conversation
@conanoc
@conanocconanoc
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
fix#840
backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.
The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
@isghe
isghe
commented
Mar 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
@lvaccaro@gabridome@Sjors

ACK 56ef036
@Sjors
Sjors
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).
@arowser
arowser
commented
Mar 23, 2018

Copy link


Copy Markdown

Contributor
Running ok on 10.12.4, but if run with lldb, show

`

2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...

2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable

2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host

2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld

2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd

2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd

2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd

2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind

2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd

2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client

2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client

2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13

2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB

Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call

Process 22701 stopped
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    
frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    
-> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    
0x7fffc80e7d44 <+12>: movq %rax, %rdi
    
0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    
0x7fffc80e7d4c <+20>: retq
    
(lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT

    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      
frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      
frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      
frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      
frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb) 
`
@conanoc
conanoc
commented
Mar 24, 2018

Copy link


Copy Markdown

ContributorAuthor
yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.
@arowser
arowser
commented
Mar 25, 2018

Copy link


Copy Markdown

Contributor
Yes, it seems not related, and the issue have been addressed in #1093
@rustyrussell
rustyrussell
self-requested a review
March 26, 2018 00:29
rustyrussell
rustyrussell
approved these changes
Mar 26, 2018
View reviewed changes
@rustyrussellrustyrussell
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399
ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?
@rustyrussell
rustyrussell
merged commit e7c8b95
into
ElementsProject:masterMar 26, 2018
@laanwj
laanwj
commented
Mar 26, 2018

Copy link


Copy Markdown

Contributor
The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.
So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS


6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable backtrace on mac - #1258
Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Mar 26, 2018
Merged
Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Conversation
@conanoc
@conanocconanoc
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
fix#840
backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.
The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
@isghe
isghe
commented
Mar 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
@lvaccaro@gabridome@Sjors

ACK 56ef036
@Sjors
Sjors
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).
@arowser
arowser
commented
Mar 23, 2018

Copy link


Copy Markdown

Contributor
Running ok on 10.12.4, but if run with lldb, show

`

2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...

2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable

2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host

2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld

2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd

2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd

2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd

2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind

2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd

2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client

2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client

2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13

2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB

Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call

Process 22701 stopped
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    
frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    
-> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    
0x7fffc80e7d44 <+12>: movq %rax, %rdi
    
0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    
0x7fffc80e7d4c <+20>: retq
    
(lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT

    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      
frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      
frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      
frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      
frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb) 
`
@conanoc
conanoc
commented
Mar 24, 2018

Copy link


Copy Markdown

ContributorAuthor
yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.
@arowser
arowser
commented
Mar 25, 2018

Copy link


Copy Markdown

Contributor
Yes, it seems not related, and the issue have been addressed in #1093
@rustyrussell
rustyrussell
self-requested a review
March 26, 2018 00:29
rustyrussell
rustyrussell
approved these changes
Mar 26, 2018
View reviewed changes
@rustyrussellrustyrussell
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399
ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?
@rustyrussell
rustyrussell
merged commit e7c8b95
into
ElementsProject:masterMar 26, 2018
@laanwj
laanwj
commented
Mar 26, 2018

Copy link


Copy Markdown

Contributor
The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.
So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS


6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Disable backtrace on mac - #1258
Merged
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Mar 26, 2018
Merged
Disable backtrace on mac#1258
rustyrussell merged 3 commits into
ElementsProject:masterfrom 
conanoc:disable_backtrace
Conversation
@conanoc
@conanocconanoc
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
fix#840
backtrace module does not support mac. So, disable crash log if BACKTRACE_SUPPORTED is 0.
The reason why this patch fix#840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
@isghe
isghe
commented
Mar 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
@lvaccaro@gabridome@Sjors

ACK 56ef036
@Sjors
Sjors
commented
Mar 22, 2018

Copy link


Copy Markdown

Contributor
Awesome, this works for me on macOS. I'm now able to connect to peers and fund channels (master crashes on launch once I have some channels open).
@arowser
arowser
commented
Mar 23, 2018

Copy link


Copy Markdown

Contributor
Running ok on 10.12.4, but if run with lldb, show

`

2018-03-23T11:19:17.428Z lightningd(22701): Trying to guess public addresses...

2018-03-23T11:19:17.459Z lightningd(22701): Address 192.168.2.211:9735 is not routable

2018-03-23T11:19:17.467Z lightningd(22701): Failed to connect 30 socket: No route to host

2018-03-23T11:19:17.469Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_channeld

2018-03-23T11:19:17.477Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_closingd

2018-03-23T11:19:17.485Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_gossipd

2018-03-23T11:19:17.492Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_hsmd

2018-03-23T11:19:17.499Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_onchaind

2018-03-23T11:19:17.508Z lightningd(22701): testing /Users/danielaof/project/lightning/lightningd/lightning_openingd

2018-03-23T11:19:17.569Z lightningd(22701): Client: Received message 11 from client

2018-03-23T11:19:17.594Z lightningd(22701): Client: Received message 9 from client

2018-03-23T11:19:17.595Z lightning_gossipd(22715): pid 22715, msgfd 13

2018-03-23T11:19:17.595Z lightningd(22701): Loaded 0 channels from DB

Waiting for /Users/danielaof/project/corebin/bitcoin-cli: Interrupted system call

Process 22701 stopped
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    
frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 libsystem_kernel.dylib__pthread_kill:
    
-> 0x7fffc80e7d42 <+10>: jae 0x7fffc80e7d4c ; <+20>
    
0x7fffc80e7d44 <+12>: movq %rax, %rdi
    
0x7fffc80e7d47 <+15>: jmp 0x7fffc80e0caf ; cerror_nocancel
    
0x7fffc80e7d4c <+20>: retq
    
(lldb) bt
  • thread Just want to say 'Thank You'. #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT

    • frame #0: 0x00007fffc80e7d42 libsystem_kernel.dylib__pthread_kill + 10 frame #1: 0x00007fffc81d55bf libsystem_pthread.dylibpthread_kill + 90
      
frame fixed typos in pdf #2: 0x00007fffc804d420 libsystem_c.dylibabort + 129 frame #3: 0x0000000100015b97 lightningdfatal(fmt="Waiting for %s: %s") at log.c:593
      
frame Missing OP_CSV in Figure 4 of the pdf #4: 0x0000000100001f1f lightningdwait_for_bitcoind(bitcoind=0x0000000100302000) at bitcoind.c:760 frame #5: 0x0000000100004340 lightningdsetup_topology(topo=0x00000001003027f0, timers=0x0000000100302270, poll_time=timerel @ 0x00007fff5fbff680, first_blocknum=101) at chaintopology.c:730
      
frame Don't use u32 locktime internally. #6: 0x0000000100012f91 lightningdmain(argc=5, argv=0x00007fff5fbff778) at lightningd.c:372 frame #7: 0x00007fffc7fb9235 libdyld.dylibstart + 1
      
frame Python implementation of onion routing spitball #8: 0x00007fffc7fb9235 libdyld.dylibstart + 1 (lldb) 
`
@conanoc
conanoc
commented
Mar 24, 2018

Copy link


Copy Markdown

ContributorAuthor
yeah. I saw the same issue with lldb. But, it's not related with this patch. You could file a new issue for that.
@arowser
arowser
commented
Mar 25, 2018

Copy link


Copy Markdown

Contributor
Yes, it seems not related, and the issue have been addressed in #1093
@rustyrussell
rustyrussell
self-requested a review
March 26, 2018 00:29
rustyrussell
rustyrussell
approved these changes
Mar 26, 2018
View reviewed changes
@rustyrussellrustyrussell
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack a599399
ignoring dirty files in libwally-core is ugly, probably need a bug report there to improve their .gitignore?
@rustyrussell
rustyrussell
merged commit e7c8b95
into
ElementsProject:masterMar 26, 2018
@laanwj
laanwj
commented
Mar 26, 2018

Copy link


Copy Markdown

Contributor
The reason why this patch fix #840 is not fully identified. On mac, SIGSEGV and SIGBUS signal happens after jsonrpc only when signal handlers are registered with sigaction().
What happens (see #840 (comment)) is that autodata (the library used for constructing RPC and other tables) uses SIGSEGV/SIGBUS on MacOSX and other BSDs to probe memory maps (in a subprocess). It registers its own handler for this, but apparently backtrace's handler also still triggers. This results in a logged error.
So this fix, removing backtrace, is overkill but it works. Another option would have been to disable backtrace handling just for autodata's subprocesses.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rustyrussellrustyrussellrustyrussell approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Fatal signal 11 received on Mac OS


6 participants

@conanoc@isghe@Sjors@arowser@laanwj@rustyrussell