Uh oh!
There was an error while loading. Please reload this page.
Re-enable ASAN when building with clang - #4013
Merged
Merged
Conversation
ContributorAuthor
Detected a use-after-free :-) See: |
darosior
commented
Sep 7, 2020
ContributorAuthor
Special-cased it too as (it's a well-known race and) i don't see how we could prevent it. |
cdecker
self-requested a review
September 7, 2020 19:19
rustyrussell
commented
Sep 8, 2020
Collaborator
Woah, a well-known use-after free? That's not good! What's happening here? Looks like the cc should be owned by NULL, so that freeing the cmd doesn't destroy it. (we'll still get a memleak if the bcli plugin crashes, but hard to care). |
darosior
commented
Sep 8, 2020
ContributorAuthor
Spent half an hour writing about how i already tried this and this doesn't work, but actually you are right. Pushed a fix and removed the suppression. |
darosior
commented
Sep 8, 2020
ContributorAuthor
(Also for the record by "well-known" i meant the functionality race, so we might have expected the data race: that was nonsensical) |
darosior
commented
Sep 8, 2020
ContributorAuthor
Travis really does not like the 100 nodes of test_funding_cancel_race under ASAN.. |
rustyrussell
commented
Sep 9, 2020
Collaborator
Hmm, if ASAN isn't going in, can you open a PR for the others? Be nice to have them in 0.9.1... |
darosior
commented
Sep 9, 2020
via email
ContributorAuthor
Sure
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
Le mercredi, septembre 9, 2020 1:19 PM, Rusty Russell <notifications@github.com> a écrit : … Hmm, if ASAN isn't going in, can you open a PR for the others? Be nice to have them in 0.9.1...
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#4013 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F3TEEDXRJTI3L3QXKLSE5QC5ANCNFSM4Q6KQAFA). |
Merged
darosiorforce-pushed
the
clang_asan
branch
3 times, most recently
from
September 10, 2020 12:17
d137f36 to
3307d7fComparedarosior
commented
Sep 10, 2020
ContributorAuthor
Trying only on the clang job now (for some reason the gcc ones produce errors..) |
cdecker
commented
Sep 19, 2020
Member
Very nice, it'd be a major improvement to be able to run lightweight sanitizers in production ( However I wonder why the suppressions are located in |
clang did the hard work here:
openingd/dualopend.c:958:42: error: result of comparison of constant 'WIRE_DUAL_OPEN_FAIL' (7003) with expression of type 'u8' (aka 'unsigned char') is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
if ((msg_type = fromwire_peektype(msg)) == WIRE_DUAL_OPEN_FAIL) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
Co-Authored-by: the clang compiler
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>ContributorAuthor
Rebased on #4076 and moved the sanitizers suppressions in contrib/ |
rustyrussell
commented
Sep 22, 2020
Collaborator
Oh, can we have a Changelog-Added: build: clang build now supports |
rustyrussell
commented
Sep 22, 2020
Collaborator
Ack 9910e5f |
darosior
commented
Sep 22, 2020
ContributorAuthor
Sure, but i doubt that Travis is going to pass anyways :/ (going to wait for it then amend) |
darosior
commented
Sep 22, 2020
ContributorAuthor
Travis still ooms on |
ContributorAuthor
Added the Changelog line. diff --git a/.travis.yml b/.travis.yml
index 6fdf5d1b5..3ac97a873 100644
--- a/.travis.yml+++ b/.travis.yml@@ -16,7 +16,7 @@ env:
- ARCH=64 TEST_CMD="make check-source check-units installcheck" DEVELOPER=1 EXPERIMENTAL_FEATURES=1
# All of the following will just run `make pytest`
- - VALGRIND=0 ARCH=64 DEVELOPER=1 COMPILER=clang+ - VALGRIND=0 ARCH=64 DEVELOPER=1 COMPILER=clang ASAN=1 LSAN_OPTIONS="suppressions=$PWD/contrib/sanitizer_suppressions/lsan"
- VALGRIND=0 ARCH=64 DEVELOPER=1 COMPILER=gcc
- VALGRIND=0 ARCH=64 DEVELOPER=0 COMPILER=gcc COMPAT=0 TEST_GROUP=1 TEST_GROUP_COUNT=2
- VALGRIND=0 ARCH=64 DEVELOPER=0 COMPILER=gcc COMPAT=0 TEST_GROUP=2 TEST_GROUP_COUNT=2 |
Prefer adding LSAN_OPTIONS="suppressions=$PWD/tests/sanitizer_suppressions/lsan" when CC=clang instead. Changelog-Added: build: clang build now supports --enable-address-sanitizer . Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking at including some fuzz targets, and will probably use clang along with its address sanitizer (and hopefully many others!).
This removes the restriction on only using gcc with ASAN, by using suppressions instead when using clang (see #2285 for the reason).
This also enables ASAN on non-already-under-valgrind Travis jobs.