implementation HTLC Endorsement to Mitigate Channel Jamming by vincenzopalazzo · Pull Request #6714 · ElementsProject/lightning

vincenzopalazzo · 2023-09-22T19:08:55Z

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo · 2023-09-22T19:08:55Z

Implementation of lightning/bolts#1071

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo · 2023-09-22T19:08:55Z

Implementation of lightning/bolts#1071

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo · 2023-09-22T19:08:55Z

Implementation of lightning/bolts#1071

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo · 2023-09-22T19:08:55Z

Implementation of lightning/bolts#1071

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo · 2023-09-22T19:08:55Z

Implementation of lightning/bolts#1071

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo · 2023-09-22T19:08:55Z

Implementation of lightning/bolts#1071

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo · 2023-09-22T19:08:55Z

Implementation of lightning/bolts#1071

The only thing is that that I think that the hook should be under and
experimental flag

vincenzopalazzo · 2023-10-24T17:03:53Z

This is quite minimal, but it includes the essential work needed to start addressing the channel mitigation issue.

Additionally, I believe it should support modifying the value of htlc_accepted. However, I'm uncertain if we need a different type of hook to fully implement the channel jamming proposal. We'll address this as it arises in the future.

rustyrussell

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

vincenzopalazzo · 2023-10-25T09:18:24Z

Looks intersesting, but not for this release, since it doesn't actually do any endorsement :)

I agree that it does not make a lot of sense to put this inside this release, not because we do not have any endorsement, but because I do not have tested it and I do not know if we need another hook or the current one is fine.

For endorsement currently, we need to implement the reputation and look at it, so I am planning to share the implementation done by Carla inside the https://github.com/LNOpenMetrics/go-lnmetrics.reporter before implementing it inside the cln builtin plugins

I know that you have an opinion on the way that how the metrics should be, so I will move incremental step before putting an effort into implementing it in C

This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Passing down to the plugins the endorsed value, using the htlc_accepted hook. Allow plugins to modify it, but I think we should have a way to limit what kind of plugins can modify the following value. This is left as a open question. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2024-01-29T09:29:57Z

Ok this is better that will go in the next release there is something that I need to do

vincenzopalazzo · 2024-01-29T17:07:41Z

Ok i need to rework this, I would like to take another approach

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch from ec3a3d2 to e399424Compare September 22, 2023 19:12

vincenzopalazzo added the protocol These issues are protocol level issues that should be discussed on the protocol spec repo label Sep 29, 2023

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch 2 times, most recently from 1818598 to d15c4c8Compare October 4, 2023 09:12

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch from d15c4c8 to 554241eCompare October 13, 2023 10:20

vincenzopalazzo requested a review from rustyrussell October 13, 2023 10:20

vincenzopalazzo added this to the v23.11 milestone Oct 13, 2023

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch from 0f5fb2b to a7eb48aCompare October 13, 2023 19:55

vincenzopalazzo marked this pull request as ready for review October 13, 2023 19:59

vincenzopalazzo marked this pull request as draft October 13, 2023 20:01

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch 5 times, most recently from bb2cbaf to 3cbaac7Compare October 18, 2023 22:14

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch 2 times, most recently from 3982077 to ffa7580Compare October 24, 2023 16:50

vincenzopalazzo marked this pull request as ready for review October 24, 2023 16:59

vincenzopalazzo requested a review from nepet October 24, 2023 17:04

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch from ffa7580 to 0178a29Compare October 24, 2023 17:07

rustyrussell reviewed Oct 25, 2023
View reviewed changes

Comment threadwire/peer_wire.csv Outdated
Comment threadlightningd/pay.c Outdated
Comment threadlightningd/pay.c Outdated
Comment threadchanneld/channeld_wire.csv Outdated

rustyrussell removed this from the v23.11 milestone Oct 25, 2023

cdecker added the needs-rebase label Jan 16, 2024

wire: adds endorsed tlv type inside the update_add_htlc
4b6470e
This commit introduce the wire change to the wire sysytem of core lightning in order to implement the [1]. [1] lightning/bolts#1071 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch 4 times, most recently from 7a75b2d to 4249cb9Compare January 28, 2024 11:11

This comment was marked as outdated.
Sign in to view

vincenzopalazzo requested review from cdecker and rustyrussell and removed request for nepet January 28, 2024 11:13

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch 3 times, most recently from 6edb5d5 to 5882f09Compare January 28, 2024 13:33

vincenzopalazzo added 3 commits January 29, 2024 10:23

lightningd: handling the endorsed field
2b898d6
Changelog-Experimental: minimal peer to peer support for the channel jamming mitigation Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

experimental: hide the jamming_endorsement under an experimetal flag
42609ca
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo force-pushed the macros/jamming-mitigation-change branch from 5882f09 to 42609caCompare January 29, 2024 09:23

vincenzopalazzo removed request for cdecker and rustyrussell January 29, 2024 09:30

vincenzopalazzo marked this pull request as draft January 29, 2024 09:30

vincenzopalazzo closed this Jan 29, 2024