setchannel: allow upgrading private channels to public by vincenzopalazzo · Pull Request #8982 · ElementsProject/lightning

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo · 2026-03-25T10:08:20Z

Summary

Add announce parameter to setchannel RPC to upgrade private channels to public
When both peers set announce=true, the channel enters the public announcement flow (exchange announcement_signatures, wait for 6 confirmations, broadcast channel_announcement)
Announcement signatures received while a channel is private are now stashed instead of rejected, enabling seamless upgrade when the peer upgrades first

Details

The channel gossip state machine gains three new transitions from CGOSSIP_PRIVATE:

CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS (normal case)
CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH (peer sigs already received)
CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED (peer sigs received + 6 confirms already reached)

Setting announce=false is rejected since public-to-private conversion is not possible.

Fixes#7438

Test plan

CI passes (build + unit tests)
Manual test: open private channel, call setchannel <id> announce=true on both sides, verify channel gets announced
Verify setchannel with announce=false returns error
Verify announcement_signatures from peer are stashed when channel is private

madelinevibes · 2026-05-04T06:49:10Z

@vincenzopalazzo can you rebase and clear CI for Rusty to review, please? Thanks!

Add an `announce` parameter to the `setchannel` RPC command that allows upgrading an existing private (unannounced) channel to a public (announced) channel. When set to true, the channel_flags are updated to set the CHANNEL_FLAGS_ANNOUNCE_CHANNEL bit, and the gossip state machine transitions from the private states into the public announcement flow. Both peers must independently set announce=true for the channel announcement to complete, as the protocol requires announcement signatures from both sides. To facilitate this, announcement_signatures received while a channel is still private are now stashed rather than rejected, so they are available immediately if/when the local side upgrades. State transitions added: - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_MATCHING_PEER_SIGS - CGOSSIP_PRIVATE -> CGOSSIP_WAITING_FOR_ANNOUNCE_DEPTH - CGOSSIP_PRIVATE -> CGOSSIP_ANNOUNCED Setting announce=false (public to private) is rejected as this is not possible once a channel has been announced. Changelog-Added: `setchannel` now accepts an `announce` parameter to upgrade private channels to public. Fixes #7438

rustyrussell · 2026-05-07T02:20:12Z

This clearly needs a test!
You need to note that this is experimental: other implementations may well consider this a spec violation!
The "Added" field needs to be changed to 26.06 in the schema.

mawroayb-ui · 2026-05-22T11:07:55Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

madelinevibes · 2026-08-03T02:24:51Z

hi @vincenzopalazzo are you planning to visit this work soon? We're working towards a release date of Aug 17 for RC1 for 26.09 so we'd need your amendments and a review before then. If not, please LMK so we can move to 26.12.

madelinevibes · 2026-08-12T08:31:07Z

I opened a small helper PR against this branch with the review-feedback pieces Rusty called out: test coverage for \setchannel announce=true, experimental docs/schema wording, \�26.06\ metadata, generated Rust RPC fields, and a clearer \�nnounce=false\ error.\n\nHelper PR: https://github.com/vincenzopalazzo/lightning/pull/9\n\nValidation I could run locally: JSON schema parsing via PowerShell \ConvertFrom-Json\ and \git diff --check. I could not run the full CLN test suite from this Windows workspace.

@mawroayb-ui if you'd like to continue this work, please open a new PR and link to the original issue #7438 so your work can be reviewed and hopefully eventually merged for the bounty!

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

vincenzopalazzo force-pushed the claude/vigilant-sammet branch 2 times, most recently from 78c96c9 to bdbb292Compare March 25, 2026 13:52

madelinevibes added the BOUNTY! 🫰 A bounty is available for this PR label Mar 30, 2026

madelinevibes added this to the 26.06 milestone Mar 30, 2026

vincenzopalazzo force-pushed the claude/vigilant-sammet branch from bdbb292 to 5ae3369Compare May 4, 2026 10:49

madelinevibes requested a review from rustyrussell May 5, 2026 05:21

madelinevibes added the PLEASE clear CI 🫠 label May 5, 2026

madelinevibes added the 26.06 RC label May 11, 2026

madelinevibes modified the milestones: v26.06, v26.09 May 11, 2026

madelinevibes removed the 26.06 RC label Jun 4, 2026

madelinevibes removed the request for review from rustyrussell August 3, 2026 02:23

vincenzopalazzo closed this Aug 11, 2026

madelinevibes mentioned this pull request Aug 12, 2026
Update an existing private channel into a public channel #7438
Open

This was referenced Aug 12, 2026
setchannel: allow upgrading private channels to public #9405
Closed
setchannel: allow upgrading private channels to public #9428
Open

Uh oh!

Conversation

vincenzopalazzo commented Mar 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Test plan

Uh oh!

madelinevibes commented May 4, 2026

Uh oh!

rustyrussell commented May 7, 2026

Uh oh!

mawroayb-ui commented May 22, 2026

Uh oh!

madelinevibes commented Aug 3, 2026

Uh oh!

madelinevibes commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

vincenzopalazzo commented Mar 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Test plan

Uh oh!

madelinevibes commented May 4, 2026

Uh oh!

rustyrussell commented May 7, 2026

Uh oh!

mawroayb-ui commented May 22, 2026

Uh oh!

madelinevibes commented Aug 3, 2026

Uh oh!

madelinevibes commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

vincenzopalazzo commented Mar 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Test plan

Uh oh!

madelinevibes commented May 4, 2026

Uh oh!

rustyrussell commented May 7, 2026

Uh oh!

mawroayb-ui commented May 22, 2026

Uh oh!

madelinevibes commented Aug 3, 2026

Uh oh!

madelinevibes commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

vincenzopalazzo commented Mar 25, 2026•
edited
Loading

vincenzopalazzo commented Mar 25, 2026•
edited
Loading

vincenzopalazzo commented Mar 25, 2026•
edited
Loading

vincenzopalazzo commented Mar 25, 2026•
edited
Loading

vincenzopalazzo commented Mar 25, 2026•
edited
Loading