Bolt quote improvements

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?

[rustyrussell]

One incredibly valuable thing about Core Lightning is we include, and enforce BOLT checks. This PR takes it to the next level:

1. Improve our tooling, so we can cover Rust, C and Python files, and get stricter with enforcement:
   1. ... at the beginning means "follows the previous quote"
   2. ... elsewhere means "skip something, but now won't skip over sections.
   3. Any comment starting with BOLT causes a complaint, ensuring we catch typos.
2. Fix up our tests and other files we now cover, to make them up-to-date.
3. Add make check-requirements-coverage to show what Requirement sections we don't quote
4. Include the bulk of them, including writing some new code where we were missing minor things

Greater coverage puts us in a much stronger position when we update to the latest BOLT version at the beginning of a release cycle.

Changelog-None: Users will never see it. Their loss!

[ddustin]

I think I've seen this CI error before, some kind of flake around askrene?

**BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command 'askrene-age'"}

[ddustin]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

[rustyrussell]

Pretty cool what Claude can do. Managing BOLT reference is apropos for a large language model 🫡

Actually, when I asked it to place the missing quotes, it was TERRIBLE. I mean, it placed them, but not next to the code which actually did the thing. Mainly because doing it right would require reading a LOT of code?