Skip to content

feat(AssetsManager): add id key param when adding an asset - #109

Merged
ripel2 merged 5 commits into
mainfrom
add-id-key-param-in-assets-manager
Mar 6, 2025
Merged

feat(AssetsManager): add id key param when adding an asset#109
ripel2 merged 5 commits into
mainfrom
add-id-key-param-in-assets-manager

Conversation

@Miou-zora

Copy link
Copy Markdown
Contributor

Not linked to any issues.

This modify API of AssetsManager to be more convenient to use with string. It can allow to use hashed string as key and then, know key in all the program even if we don't get it through creation of asset

@Miou-zoraMiou-zora added the enhancement New feature or request label Mar 6, 2025
@Miou-zora
Miou-zora requested a review from a teamMarch 6, 2025 08:54
@Miou-zoraMiou-zora self-assigned this Mar 6, 2025
@sonarqubecloud

Copy link
Copy Markdown

@ripel2ripel2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ripel2
ripel2 merged commit 606dc2a into mainMar 6, 2025
@ripel2
ripel2 deleted the add-id-key-param-in-assets-manager branch March 6, 2025 15:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Miou-zora@ripel2