Uh oh!
There was an error while loading. Please reload this page.
feat(core): add optional default fallback resource to ResourceManager - #390
Merged
Miou-zora merged 9 commits intoNov 24, 2025
Merged
Conversation
Co-authored-by: Miou-zora <91665686+Miou-zora@users.noreply.github.com>
Co-authored-by: Miou-zora <91665686+Miou-zora@users.noreply.github.com>
Co-authored-by: Miou-zora <91665686+Miou-zora@users.noreply.github.com>
Co-authored-by: Miou-zora <91665686+Miou-zora@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Add optional default element in ResourceManagerAdd optional default fallback resource to ResourceManagerNov 23, 2025
Miou-zora
marked this pull request as ready for review
November 24, 2025 09:32
Miou-zora
commented
Nov 24, 2025
Contributor
Related to: Note I also fixed the way we are creating resource inside |
ripel2
approved these changes
Nov 24, 2025
Uh oh!
There was an error while loading. Please reload this page.
Miou-zora added a commit
that referenced
this pull request
Jan 5, 2026
…#390) Adds ability to designate a default resource that `ResourceManager` returns when a requested resource doesn't exist, useful for fallback textures/shaders/meshes. **API additions:** - `SetDefault(ResourceType)` - designates an existing resource as the fallback - `GetOrDefault(ResourceType)` - returns requested resource or default if not found (const and non-const) - `HasDefault()` - checks if default is set **Implementation:** - Stores default resource in `std::optional<ResourceType>` - Throws `ResourceManagerError` if setting non-existent default set Existing `Get()` behavior unchanged for strict validation use cases. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Miou-zora <91665686+Miou-zora@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to designate a default resource that
ResourceManagerreturns when a requested resource doesn't exist, useful for fallback textures/shaders/meshes.API additions:
SetDefault(ResourceType)- designates an existing resource as the fallbackGetOrDefault(ResourceType)- returns requested resource or default if not found (const and non-const)HasDefault()- checks if default is setImplementation:
std::optional<ResourceType>ResourceManagerErrorif setting non-existent default setExisting
Get()behavior unchanged for strict validation use cases.