You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh actually pub fn LLVMRustAddRetAttr(V: &Value, attr: AttributeKind); here you should have used Attr, like you did in the other function that you added, but I'll fix it in the PR2. The reason is that AttributeKind is one of the enum variant hardcoded by rustc, but we create our own Attributes, containing tt.
Also, you named the Rust version LLVMRustAddRetAttr, and the C version LLVMRustAddRetFncAttr. These two files exist s.t. the linker can link the Rust version against the C version (which wrapps the real, c++ version), so they have to have identical names to allow the linker to link the c implementation against the rust declaration (linkers ignore argument numbers and types, they only go after names).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the functions
LLVMRustAddFncParamAttrandLLVMRustAddRetFncAttrto RustWrapper.cpp.This will be used so that later we can link type trees to specific parameters/return value for Enzyme.
For the c->rust wrapper, do I add an implementation for the
LLVMRustAddFncParamAttr,LLVMRustAddRetAttrfunctions?Also do I need lines 6-7?