Uh oh!
There was an error while loading. Please reload this page.
Checking if the result of a query or query_one function is not empty or nullptr - #499
Merged
Merged
Conversation
change convert function move connection string modifying functions to dbutil smaller typo and formatting fixes change connenctionstring only with pgsql change back everything and adding quotation marks
In an earlier commit (a8a1502) there was a bugfix which related to fetching "is virtual" tag of a function pointer. Of course function pointers can't have this flag. This previous commit fixed this issue on server-side, however, it was the parser's fault that the symbol type in a call expression was set to function even if it was a function pointer.
CallExpr can be applied to a function pointer
…mpass into matebelenyesi-query_check
mcserep
requested changes
Jan 9, 2021
mcserep
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Since these cases should not occur, maybe add some warning messages to the output, so we can easily identify them later?
| AstQuery::astType == model::CppAstNode::AstType::Definition); | ||
| nodes.insert(nodes.end(), result.begin(), result.end()); | ||
| if(!result.empty()) | ||
| nodes.insert(nodes.end(), result.begin(), result.end()); |
Collaborator
There was a problem hiding this comment.
Is this required? Does not the vector handles the empty range when inserting? (When first == last.)
Collaborator
There was a problem hiding this comment.
Yes, it is ok to v.insert( v.end(), ...)
Moreover, if we are about to insert the first element to the vector than we have an empty vector. So this fix may deny us to insert one (or more) elements.
| FileQuery::id == std::stoull(range_.file)); | ||
| if(!file) | ||
| return; |
Collaborator
There was a problem hiding this comment.
Should be joined with the following check.
…oving unnecessary empty vector checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.