Uh oh!
There was an error while loading. Please reload this page.
Fix C++ parser relative path - #516
Merged
Merged
Conversation
C++ parser is working based on a compilation_database.json file. This file may contain relative file paths in its "file" attributes. This file is given to C++ parser to build the AST of this file. However, this works only if the filename is correctly relative to the current working directory. In this patch the directory and file components are joined so the full path of a source file is passed to the parser.
bruntibforce-pushed
the
fix_cpp_parser_relative_path
branch
from
February 20, 2021 11:16
e6b5030 to
04826d2Comparemcserep
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ parser is working based on a compilation_database.json file.
This file may contain relative file paths in its "file" attributes.
This file is given to C++ parser to build the AST of this file.
However, this works only if the filename is correctly relative to
the current working directory.
In this patch the directory and file components are joined so the
full path of a source file is passed to the parser.