Skip to content

Reducing the number of db connections at runtime - #589

Merged
mcserep merged 1 commit into
Ericsson:masterfrom
intjftw:db-connections
Jan 12, 2023
Merged

Reducing the number of db connections at runtime#589
mcserep merged 1 commit into
Ericsson:masterfrom
intjftw:db-connections

Conversation

@intjftw

Copy link
Copy Markdown
Contributor

In this PR I made the util library shared instead of static. This way each parsed project shall open one connection to the database at webserver runtime instead of each plugin opening its own connection per project.

@mcserep thank you for your help with this.

Fixes#485.

@intjftwintjftw added this to the Release Gershwin milestone Jan 11, 2023
@mcserepmcserep added Kind: Refactor 🔃 Target: Service Issues related to the Thrift service. labels Jan 11, 2023

@mcserepmcserep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mcserep
mcserep merged commit b488530 into Ericsson:masterJan 12, 2023
@intjftw
intjftw deleted the db-connections branch January 12, 2023 16:25
@mcserepmcserep added the Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI. label Jan 16, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind: Refactor 🔃Target: Developer environmentDeveloper environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI.Target: ServiceIssues related to the Thrift service.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugins should share their database connection pool

2 participants

@intjftw@mcserep