Expand user in the CodeChecker binary path by csordasmarton · Pull Request #98 · Ericsson/CodecheckerVSCodePlugin

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton · 2022-02-23T10:24:01Z

We are using spawn method to execute a CodeChecker command.
If the executable path starts with a ~ (e.g.: ~/CodeChecker/bin/CodeChecker),
the spawn method doesn't work properly and will give an exception.

For more information see: nodejs/node#684

To solve this problem we will expand the ~ in the file path before
executing the command.

Discookie

One small thing, otherwise LGTM!
I would've preferred a library for this, but for this simple one it's good enough.

Discookie · 2022-02-28T03:05:44Z


+// Expand an initial '~' component in the given path if there is any, otherwise returns the file path without changes.
+function expandUser(filePath: string) {
+ return os.homedir ? filePath.replace(/^~(?=$|\/|\\)/, os.homedir) : filePath;


os.homedir is a function, not a string.
Technically it still works because .replace() accepts a (...) => string as second argument, but it'll fail on systems with no homedir.

We are using `spawn` method to execute a CodeChecker command. If the executable path starts with a `~` (e.g.: `~/CodeChecker/bin/CodeChecker`), the `spawn` method doesn't work properly and will give an exception. For more information see: nodejs/node#684 To solve this problem we will expand the `~` in the file path before executing the command.

Discookie

LGTM!

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

csordasmarton added the bugfix label Feb 23, 2022

csordasmarton added this to the 1.3.0 milestone Feb 23, 2022

csordasmarton requested a review from Discookie February 23, 2022 10:24

Discookie requested changes Feb 28, 2022
View reviewed changes

csordasmarton force-pushed the cc_path_expand_user branch from d8017f4 to a4bd18eCompare February 28, 2022 12:58

csordasmarton requested a review from Discookie February 28, 2022 12:58

Discookie approved these changes Feb 28, 2022
View reviewed changes

Discookie merged commit fc426e2 into Ericsson:mainFeb 28, 2022

Uh oh!

Conversation

csordasmarton commented Feb 23, 2022

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

DiscookieFeb 28, 2022

Choose a reason for hiding this comment

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

csordasmarton commented Feb 23, 2022

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

DiscookieFeb 28, 2022

Choose a reason for hiding this comment

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

csordasmarton commented Feb 23, 2022

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

DiscookieFeb 28, 2022

Choose a reason for hiding this comment

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

csordasmarton commented Feb 23, 2022

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

DiscookieFeb 28, 2022

Choose a reason for hiding this comment

Uh oh!

Discookie left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects