Skip to content

Various improvements to local chat - #4535

Merged
JRoy merged 6 commits into
EssentialsX:2.xfrom
JRoy:feat/chat-improvements
Feb 14, 2022
Merged

Various improvements to local chat #4535
JRoy merged 6 commits into
EssentialsX:2.xfrom
JRoy:feat/chat-improvements

Conversation

@JRoy

@JRoyJRoy commented Sep 17, 2021

Copy link
Copy Markdown
Member

Tracking ideas from #4509

  • Config option for default shout state (Should players default to local or shout mode)
    • chat:
      ...# Whether players should be placed into shout mode by default.shout-default: false
  • Persist shouting state between restarts (in userdata) (add config option for this)
    • chat:
      ...# Whether a player's shout mode should persist restarts.persist-shout: false
  • Config option for question chat
    • chat:
      ...# Whether chat questions should be enabled or not.question-enabled: true
  • Permission for sending to local chat (like global and question has)
    • essentials.chat.local defaults to true
  • Permissions for receiving chat channels
    • Adds the following permissions which default to true: essentials.chat.receive.local, essentials.chat.receive.shout, and essentials.chat.receive.question.
  • Improve local chat prefix (color, spacing)
  • Using the shout prefix (! by default) while toggle shout is enabled will now send a message in local chat.

@JRoyJRoy added type: enhancement Features and feature requests. module: chat Issues or PRs for the EssentialsChat module labels Sep 17, 2021
@JRoy
JRoy marked this pull request as ready for review September 29, 2021 02:04
@JRoy
JRoyforce-pushed the feat/chat-improvements branch 2 times, most recently from 3ac5966 to 7e54d22CompareSeptember 30, 2021 01:09
@JRoy
JRoy enabled auto-merge (rebase) September 30, 2021 01:10
@JRoy
JRoyforce-pushed the feat/chat-improvements branch 2 times, most recently from 813c8cb to 296d42aCompareOctober 13, 2021 01:57
pop4959
pop4959 previously approved these changes Oct 28, 2021
@JRoy
JRoyforce-pushed the feat/chat-improvements branch from 296d42a to 3f09baaCompareNovember 6, 2021 20:57
@JRoy
JRoyforce-pushed the feat/chat-improvements branch from 3f09baa to 9ae9f4fCompareNovember 24, 2021 16:18
@JRoy
JRoyforce-pushed the feat/chat-improvements branch from 9ae9f4f to a8f2039CompareDecember 16, 2021 01:10
@JRoy
JRoyforce-pushed the feat/chat-improvements branch from a8f2039 to 615865dCompareDecember 26, 2021 15:39
mdcfe
mdcfe previously requested changes Dec 29, 2021
Comment threadEssentials/src/main/resources/messages.properties
Comment threadEssentials/src/main/resources/messages.properties Outdated
Comment threadEssentials/src/main/resources/config.yml
@mdcfemdcfe added this to the 2.20.0 milestone Dec 29, 2021
@JRoy
JRoyforce-pushed the feat/chat-improvements branch from 615865d to 4d1a64bCompareDecember 29, 2021 14:56
@JRoy
JRoyforce-pushed the feat/chat-improvements branch from 4d1a64b to b592b7cCompareFebruary 1, 2022 22:35
@JRoy
JRoyforce-pushed the feat/chat-improvements branch from b592b7c to f26547eCompareFebruary 14, 2022 03:41
@JRoy
JRoy merged commit cbb0128 into EssentialsX:2.xFeb 14, 2022
@JRoy
JRoy deleted the feat/chat-improvements branch February 22, 2022 13:35
@mdcfemdcfe modified the milestones: 2.20.0, 2.19.3Feb 23, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: chatIssues or PRs for the EssentialsChat moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JRoy@mdcfe@pop4959