We're going on an Adventure! by JRoy · Pull Request #4717 · EssentialsX/Essentials

JRoy · 2021-12-28T05:20:55Z

im.going.on.an.adventure.mp4

Closes#2029
Closes#2391

Todo

Per Player Locale
- Add support for them
- Finish porting everything over to per-player-locale system.
MiniMessage Support (Components - Hover/Click Events)
- No messages will be converted to MiniMessage in this PR, a separate PR will add this.
- Currently, there are a few messages which are a giant pain in the ass to convert to support components. They will be converted on a need-to basis.

Turns out that adventure-platform registers events which are required to create an audience for them. Move the creation of the BukkitAudiences object after we unregister all of our events.

…is i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this

…y head get out of my head get out of my head get out of my head get out of my head

… i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die

This reverts commit 90103ba.

…g-on-an-adventure

TheKrafter · 2023-11-24T04:10:05Z

Just your friendly neighborhood server admin, I was wondering if we could get a progress report of some kind. I really appreciate yall's work, and also had a few questions regarding these changes that the answers to are probably well-known to EssentialsX developers, but I have not been able find answers to elsewhere:

Does this PR add PlaceholderAPI Support? (as Add PlaceholderAPI support #2041 started, then was closed in favor of Implement per player locale (Implements #2029) #2502, which was closed in favor of this PR)
Does this PR add MiniPlaceholder support?
Would the {PLACEHOLDER} style placeholders in configs and *.txt files need to be modified?

I don't want to be a nag, but I really do appreciate your work and would like to know how this all is going so far, thank you all very much!

Co-authored-by: pop4959 <pop4959@gmail.com>

people may forget what these things do later

codebycam · 2024-01-27T00:42:40Z

LGTM

Still LGTM

SrBedrock · 2024-02-03T19:35:16Z

When a player joins the server, an error is sent: https://pastes.dev/YbBHLlf2fw
When trying to receive messages from Essentials an error is sent: https://pastes.dev/lB3llBOiDM

mbax · 2024-02-03T20:07:18Z

When a player joins the server, an error is sent: https://pastes.dev/YbBHLlf2fw When trying to receive messages from Essentials an error is sent: https://pastes.dev/lB3llBOiDM

Any chance you were live swapping the EssX jar in the plugins folder instead of using plugins/update ?

mdcfe · 2024-02-03T20:28:33Z

@SrBedrock The PR has been updated to shade the missing options library - would you be able to update to the latest dev build?

https://user-images.githubusercontent.com/10731363/147530817-f9adc58e-18a5-49ed-84c6-106e51d6948f.mp4 Add support for chat components throughout EssentialsX using the Adventure library. Translations have been converted to the MiniMessage format, and custom message files will be migrated on startup. This also introduces new options to allow players to see messages in their own language and for server owners to change the main message colours without editing message files. ClosesEssentialsX#2029ClosesEssentialsX#2391 --------- Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com> Co-authored-by: pop4959 <pop4959@gmail.com>

JRoy added 3 commits December 26, 2021 12:28

Fix bstats *still* being transitive
28d562e

Add support for per-player-locale and MiniMessage
c1af477

Begin per-player-locale conversion
aade96c

JRoy added this to the 2.20.0 milestone Dec 28, 2021

zml2008 suggested changes Dec 28, 2021
View reviewed changes

Comment threadEssentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java Outdated

JRoy added 6 commits December 28, 2021 12:40

Prevent all locales from falling back to English
d4e9f57

zml woke up
54617e2

Bump adventure, moar debug
2ffeb00

Bump run-paper
aafaf94

Fix audiences not working
17709e2
Turns out that adventure-platform registers events which are required to create an audience for them. Move the creation of the BukkitAudiences object after we unregister all of our events.

JRoy force-pushed the refactor/we-are-going-on-an-adventure branch from 8c538dc to 2f38558Compare December 28, 2021 23:19

get out of my head get out of my head get out of my head get out of m…
14c532f
…y head get out of my head get out of my head get out of my head get out of my head

kashike reviewed Dec 29, 2021
View reviewed changes

Comment threadEssentials/src/main/java/com/earth2me/essentials/CommandSource.java Outdated

JRoy added 8 commits December 29, 2021 09:36

Move MiniMessage prefix to constant
3d78dfe

Merge branch '2.x' into refactor/we-are-going-on-an-adventure
66e5977

Actually support TranslatableException in EssentialsCommand#showError
07f9320

Give CommandSource an Essentials instance on creation
cd8c8df

Bump checkstyle
90103ba

Revert "Bump checkstyle"
cbcce93
This reverts commit 90103ba.

some progress or whatever
63b5974

JRoy added 4 commits November 5, 2023 18:20

Support named colors for customizable color codes
7667176

Support customizable colors for the upgrade
6acd45d

Enable the upgrade
8012e93

Merge remote-tracking branch 'upstream/2.x' into refactor/we-are-goin…
7858beb
…g-on-an-adventure

mdcfeand others added 7 commits December 17, 2023 17:31

Update Essentials/src/main/java/com/earth2me/essentials/Essentials.java
0385dc7
Co-authored-by: pop4959 <pop4959@gmail.com>

Merge branch '2.x' into refactor/we-are-going-on-an-adventure
9c4715c

Bump Adventure
86862f6

Move custom message files to separate directory
d0cbe26

Fix minor adventure trolling
f9a2afe

Preserve messages order
2d86f6f

Add some javadocs
ae7590a
people may forget what these things do later

mdcfe added 4 commits February 3, 2024 15:57

Merge branch '2.x' into refactor/we-are-going-on-an-adventure
f14f5df

Merge branch '2.x' into refactor/we-are-going-on-an-adventure
1646427

Update messages files to use MiniMessage
521c5e1

Set up BukkitAudiences in unit tests
ef2da87

mdcfe previously approved these changes Feb 3, 2024
View reviewed changes

Shade kyori option lib
9730d61

mdcfe dismissed their stale review via 9730d61February 3, 2024 20:22

mdcfe approved these changes Feb 3, 2024
View reviewed changes

mdcfe merged commit 388d571 into 2.xFeb 3, 2024

mdcfe deleted the refactor/we-are-going-on-an-adventure branch February 3, 2024 20:38

sarhatabaot added a commit to Lapzupi/Essentials that referenced this pull request Apr 6, 2024
Fixes issues fromEssentialsX#4717
e154e68

Navigation Menu

Uh oh!

Uh oh!

We're going on an Adventure! - #4717

We're going on an Adventure!#4717
mdcfe merged 129 commits into
2.xfrom
refactor/we-are-going-on-an-adventure

JRoy commented Dec 28, 2021•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

TheKrafter commented Nov 24, 2023•
edited
Loading

Uh oh!

codebycam commented Jan 27, 2024

Uh oh!

SrBedrock commented Feb 3, 2024•
edited
Loading

Uh oh!

mbax commented Feb 3, 2024

Uh oh!

mdcfe commented Feb 3, 2024•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Uh oh!

Conversation

JRoy commented Dec 28, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Uh oh!

Uh oh!

Uh oh!

TheKrafter commented Nov 24, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codebycam commented Jan 27, 2024

Uh oh!

SrBedrock commented Feb 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbax commented Feb 3, 2024

Uh oh!

mdcfe commented Feb 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

JRoy commented Dec 28, 2021•
edited
Loading

TheKrafter commented Nov 24, 2023•
edited
Loading

SrBedrock commented Feb 3, 2024•
edited
Loading

mdcfe commented Feb 3, 2024•
edited
Loading