Skip to content

Added option to limit amount of lore lines - #4773

Merged
JRoy merged 7 commits into
EssentialsX:2.xfrom
justinmtech:feature-max-lore-4772
Aug 8, 2023
Merged

Added option to limit amount of lore lines#4773
JRoy merged 7 commits into
EssentialsX:2.xfrom
justinmtech:feature-max-lore-4772

Conversation

@justinmtech

@justinmtechjustinmtech commented Jan 21, 2022•
edited
Loading

Copy link
Copy Markdown

Information

This PR closes #4772

Details

Proposed feature:

Configure the max lines of lore that can be added with /itemlore add.
Adds config setting "max-item-lore" and an error message when a user tries to add a new line of lore to an item with the max.
#4772

Environments tested:

OS: Windows 10

Java version: OpenJDK 17.0.1

Demonstration:

Screenshot: https://imgur.com/a/dQ6TedQ
Plugin Download: https://www.dropbox.com/s/jpl35j9rr57bs8m/EssentialsX-2.19.3-dev%2B10-b220c22-max-lore-feature-4772.jar?dl=0

JRoy
JRoy requested changes Jan 23, 2022
View reviewed changes

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things plus please add a essentials.itemlore.bypass permission to bypass this limit

Comment threadEssentials/src/main/resources/config.yml Outdated
Comment threadEssentials/src/main/java/com/earth2me/essentials/Settings.java Outdated
Comment threadEssentials/src/main/resources/messages.properties Outdated
justinmtechand others added 3 commits January 22, 2022 19:02
@justinmtech@JRoy
Update Essentials/src/main/resources/config.yml
cfa9d9d
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
@justinmtech@JRoy
Update Essentials/src/main/java/com/earth2me/essentials/Settings.java
5ea7af2
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
@justinmtech@JRoy
Update Essentials/src/main/resources/messages.properties
f36a766
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
@justinmtech

justinmtech commented Jan 23, 2022•
edited
Loading

Copy link
Copy Markdown
Author

Thanks! Looks good to me. I'll add the bypass shortly.

@JRoyJRoy added status: waiting on author Pull requests that require changes from the author in order to merge. type: enhancement Features and feature requests. labels Jan 28, 2022
@mdcfe

mdcfe commented Mar 19, 2022

Copy link
Copy Markdown
Member

Hey @justinmtech, any updates on these changes?

@pop4959pop4959 added the module: main Issues or PRs for the main Essentials module label May 21, 2022
JRoy
JRoy approved these changes Aug 8, 2023
View reviewed changes
@JRoyJRoy changed the title Added max lore feature request #4772Added option to limit amount of lore linesAug 8, 2023
@JRoy
JRoy enabled auto-merge (squash) August 8, 2023 18:46
@JRoy
JRoy merged commit eb76cf0 into EssentialsX:2.xAug 8, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
Justin@JRoy@Starmism
Added option to limit amount of lore lines (EssentialsX#4773)
0a75a8b
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
Justin@JRoy
Added option to limit amount of lore lines (EssentialsX#4773)
e8af447
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees

No one assigned

Labels

module: mainIssues or PRs for the main Essentials modulestatus: waiting on authorPull requests that require changes from the author in order to merge.type: enhancementFeatures and feature requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinmtech@mdcfe@JRoy@pop4959